From b1eec66640af3d1940f74484fe1a3c0487204801 Mon Sep 17 00:00:00 2001 From: Ben Kochie Date: Wed, 7 Nov 2018 17:21:18 +0100 Subject: [PATCH] Add TCPSynRetrans to netstat default filter (#1143) Tcp SYN packet retransmits are a very useful signal as they affect network performance disproportionately to regular TCP retransmits. Signed-off-by: Ben Kochie --- CHANGELOG.md | 2 +- collector/netstat_linux.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c6e79c83..a9cdf09f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ ### Changes * [BUGFIX] -* [CHANGE] +* [CHANGE] Add TCPSynRetrans to netstat default filter #1143 * [ENHANCEMENT] Add Infiniband counters #1120 * [FEATURE] diff --git a/collector/netstat_linux.go b/collector/netstat_linux.go index b9584deb..e0812a70 100644 --- a/collector/netstat_linux.go +++ b/collector/netstat_linux.go @@ -33,7 +33,7 @@ const ( ) var ( - netStatFields = kingpin.Flag("collector.netstat.fields", "Regexp of fields to return for netstat collector.").Default("^(.*_(InErrors|InErrs)|Ip_Forwarding|Ip(6|Ext)_(InOctets|OutOctets)|Icmp6?_(InMsgs|OutMsgs)|TcpExt_(Listen.*|Syncookies.*)|Tcp_(ActiveOpens|PassiveOpens|RetransSegs|CurrEstab)|Udp6?_(InDatagrams|OutDatagrams|NoPorts))$").String() + netStatFields = kingpin.Flag("collector.netstat.fields", "Regexp of fields to return for netstat collector.").Default("^(.*_(InErrors|InErrs)|Ip_Forwarding|Ip(6|Ext)_(InOctets|OutOctets)|Icmp6?_(InMsgs|OutMsgs)|TcpExt_(Listen.*|Syncookies.*|TCPSynRetrans)|Tcp_(ActiveOpens|PassiveOpens|RetransSegs|CurrEstab)|Udp6?_(InDatagrams|OutDatagrams|NoPorts))$").String() ) type netStatCollector struct {