RepoMirrors/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter synced 2025-01-10 07:29:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move regexp to global in meminfo_linux.go

Browse Source 
Compile regexp outside of parsing function in meminfo_linux.go

Signed-off-by: Shapor Naghibzadeh <shapor@google.com>
This commit is contained in:
Shapor Naghibzadeh 2020-04-26 01:04:25 -07:00 committed by Shapor Naghibzadeh
parent 091bed01b0
commit a1a3633d89
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
collector/meminfo_linux.go
View File

@ -25,6 +25,10 @@ import (
"strings"
)
var (
reParens = regexp.MustCompile(`\((.*)\)`)
)
func (c *meminfoCollector) getMemInfo() (map[string]float64, error) {
file, err := os.Open(procFilePath("meminfo"))
if err != nil {
@ -39,7 +43,6 @@ func parseMemInfo(r io.Reader) (map[string]float64, error) {
var (
memInfo = map[string]float64{}
scanner = bufio.NewScanner(r)
re = regexp.MustCompile(`\((.*)\)`)
)
for scanner.Scan() {
@ -55,7 +58,7 @@ func parseMemInfo(r io.Reader) (map[string]float64, error) {
}
key := parts[0][:len(parts[0])-1] // remove trailing : from key
// Active(anon) -> Active_anon
key = re.ReplaceAllString(key, "_${1}")
key = reParens.ReplaceAllString(key, "_${1}")
switch len(parts) {
case 2: // no unit
case 3: // has unit, we presume kB