From 2a282668522b2dcbd38e0aa9c55693a89e22e610 Mon Sep 17 00:00:00 2001
From: Benjamin Drung <benjamin.drung@ionos.com>
Date: Fri, 29 Oct 2021 10:55:39 +0200
Subject: [PATCH] ethtool: Add test case with leading spaces (#2186)

Add test case for ethtool metrics with leading spaces reported in #2185:

```
$ ethtool -S
NIC statistics:
     Tx Queue#: 0
       TSO pkts tx: 0
       TSO bytes tx: 0
       ucast pkts tx: 20487
       ucast bytes tx: 1908107
       mcast pkts tx: 83
       mcast bytes tx: 5906
       bcast pkts tx: 4
       bcast bytes tx: 168
       pkts tx err: 0
       pkts tx discard: 0
       drv dropped tx total: 0
          too many frags: 0
          giant hdr: 0
          hdr err: 0
          tso: 0
       ring full: 0
       pkts linearized: 0
       hdr cloned: 0
       giant hdr: 0
     Rx Queue#: 0
       LRO pkts rx: 0
       LRO byte rx: 0
       ucast pkts rx: 25086
       ucast bytes rx: 2404103
       mcast pkts rx: 0
       mcast bytes rx: 0
       bcast pkts rx: 0
       bcast bytes rx: 0
       pkts rx OOB: 0
       pkts rx err: 0
       drv dropped rx total: 0
          err: 0
          fcs: 0
       rx buf alloc fail: 0
     tx timeout count: 0
```

Bug: https://github.com/prometheus/node_exporter/issues/2185
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
---
 collector/ethtool_linux_test.go | 1 +
 collector/helper_test.go        | 1 +
 2 files changed, 2 insertions(+)

diff --git a/collector/ethtool_linux_test.go b/collector/ethtool_linux_test.go
index 88e91106..761351c6 100644
--- a/collector/ethtool_linux_test.go
+++ b/collector/ethtool_linux_test.go
@@ -270,6 +270,7 @@ func TestBuildEthtoolFQName(t *testing.T) {
 		"Tx LPI entry count":           "node_ethtool_transmitted_lpi_entry_count",
 		"port.VF_admin_queue_requests": "node_ethtool_port_vf_admin_queue_requests",
 		"[3]: tx_bytes":                "node_ethtool_3_transmitted_bytes",
+		"     err":                     "node_ethtool_err",
 	}
 
 	for metric, expected := range testcases {
diff --git a/collector/helper_test.go b/collector/helper_test.go
index e19e5691..15fe5054 100644
--- a/collector/helper_test.go
+++ b/collector/helper_test.go
@@ -70,6 +70,7 @@ func TestSanitizeMetricName(t *testing.T) {
 		"Tx LPI entry count":           "Tx_LPI_entry_count",
 		"port.VF_admin_queue_requests": "port_VF_admin_queue_requests",
 		"[3]: tx_bytes":                "_3_tx_bytes",
+		"     err":                     "_err",
 	}
 
 	for metricName, expected := range testcases {