RepoMirrors
/
node_exporter
mirror of https://github.com/prometheus/node_exporter
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix smartmon.sh bugs (#792) 

* Fix smartmon.sh info label consistency.

* Fix parsing of SMART-ID attributes <= 99.
This commit is contained in:
Ben Kochie 2018-01-22 16:51:20 +01:00 committed by GitHub
parent 6cac74f0e0
commit 1ad5ba4dc7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
text_collector_examples/smartmon.sh
View File

@ -8,7 +8,7 @@
# http://arstechnica.com/civis/viewtopic.php?p=22062211 # http://arstechnica.com/civis/viewtopic.php?p=22062211
parse_smartctl_attributes_awk="$(cat << 'SMARTCTLAWK' parse_smartctl_attributes_awk="$(cat << 'SMARTCTLAWK'
$1 ~ /^[0-9]+$/ && $2 ~ /^[a-zA-Z0-9_-]+$/ { $1 ~ /^ *[0-9]+$/ && $2 ~ /^[a-zA-Z0-9_-]+$/ {
gsub(/-/, "_"); gsub(/-/, "_");
printf "%s_value{%s,smart_id=\"%s\"} %d\n", $2, labels, $1, $4 printf "%s_value{%s,smart_id=\"%s\"} %d\n", $2, labels, $1, $4
printf "%s_worst{%s,smart_id=\"%s\"} %d\n", $2, labels, $1, $5 printf "%s_worst{%s,smart_id=\"%s\"} %d\n", $2, labels, $1, $5
@ -71,6 +71,7 @@ parse_smartctl_attributes() {
parse_smartctl_info() { parse_smartctl_info() {
local -i smart_available=0 smart_enabled=0 smart_healthy=0 local -i smart_available=0 smart_enabled=0 smart_healthy=0
local disk="$1" disk_type="$2" local disk="$1" disk_type="$2"
local model_family='' device_model='' serial_number='' fw_version='' vendor='' product='' revision='' lun_id=''
while read line ; do while read line ; do
info_type="$(echo "${line}" | cut -f1 -d: | tr ' ' '_')" info_type="$(echo "${line}" | cut -f1 -d: | tr ' ' '_')"
info_value="$(echo "${line}" | cut -f2- -d: | sed 's/^ \+//g')" info_value="$(echo "${line}" | cut -f2- -d: | sed 's/^ \+//g')"
@ -101,11 +102,7 @@ parse_smartctl_info() {
esac esac
fi fi
done done
if [[ -n "${vendor}" ]] ; then echo "device_info{disk=\"${disk}\",type=\"${disk_type}\",vendor=\"${vendor}\",product=\"${product}\",revision=\"${revision}\",lun_id=\"${lun_id}\",model_family=\"${model_family}\",device_model=\"${device_model}\",serial_number=\"${serial_number}\",firmware_version=\"${fw_version}\"} 1"
echo "device_info{disk=\"${disk}\",type=\"${disk_type}\",vendor=\"${vendor}\",product=\"${product}\",revision=\"${revision}\",lun_id=\"${lun_id}\"} 1"
else
echo "device_info{disk=\"${disk}\",type=\"${disk_type}\",model_family=\"${model_family}\",device_model=\"${device_model}\",serial_number=\"${serial_number}\",firmware_version=\"${fw_version}\"} 1"
fi
echo "device_smart_available{disk=\"${disk}\",type=\"${disk_type}\"} ${smart_available}" echo "device_smart_available{disk=\"${disk}\",type=\"${disk_type}\"} ${smart_available}"
echo "device_smart_enabled{disk=\"${disk}\",type=\"${disk_type}\"} ${smart_enabled}" echo "device_smart_enabled{disk=\"${disk}\",type=\"${disk_type}\"} ${smart_enabled}"
echo "device_smart_healthy{disk=\"${disk}\",type=\"${disk_type}\"} ${smart_healthy}" echo "device_smart_healthy{disk=\"${disk}\",type=\"${disk_type}\"} ${smart_healthy}"