From 0b6763886ac9a8dba8a9415487943b7984c2a86c Mon Sep 17 00:00:00 2001 From: Pontus Leitzler Date: Wed, 18 Oct 2017 07:38:48 +0200 Subject: [PATCH] Remove unnecessary select statement (#692) * Remove unnecessary select statement * Remove unnecessary if-statement --- node_exporter_test.go | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/node_exporter_test.go b/node_exporter_test.go index a1a214c9..5a9599ec 100644 --- a/node_exporter_test.go +++ b/node_exporter_test.go @@ -129,14 +129,9 @@ func runCommandAndTests(cmd *exec.Cmd, address string, fn func(pid int) error) e errc <- fn(pid) }(cmd.Process.Pid) - select { - case err := <-errc: - if cmd.Process != nil { - cmd.Process.Kill() - } - if err != nil { - return err - } + err := <-errc + if cmd.Process != nil { + cmd.Process.Kill() } - return nil + return err }