RepoMirrors/netlink
1
0
Fork 0
mirror of https://github.com/vishvananda/netlink synced 2025-03-25 04:26:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set default values for link attributes

Browse Source 
When deserializing a link related netlink message, if no network namespace id
attribute is specified, we need to set it to -1 otherwise it defaults to 0
which is a valid id. Using NewLinkAttrs sets the default values and allows
the user to distinguish an empty value from a missing value
This commit is contained in:
Sylvain Baubeau 2020-08-26 10:12:55 +02:00 committed by Vish (Ishaya) Abrams
parent 98629f7ffc
commit fe26ba2db0
2 changed files with 7 additions and 2 deletions

3
link.go
View File

@ -103,7 +103,8 @@ func (s LinkOperState) String() string {
// NewLinkAttrs returns LinkAttrs structure filled with default values // NewLinkAttrs returns LinkAttrs structure filled with default values
func NewLinkAttrs() LinkAttrs { func NewLinkAttrs() LinkAttrs {
return LinkAttrs{ return LinkAttrs{
TxQLen: -1, NetNsID: -1,
TxQLen: -1,
} }
} }

6
link_linux.go
View File

@ -1566,7 +1566,11 @@ func LinkDeserialize(hdr *unix.NlMsghdr, m []byte) (Link, error) {
return nil, err return nil, err
} }
base := LinkAttrs{Index: int(msg.Index), RawFlags: msg.Flags, Flags: linkFlags(msg.Flags), EncapType: msg.EncapType()} base := NewLinkAttrs()
base.Index = int(msg.Index)
base.RawFlags = msg.Flags
base.Flags = linkFlags(msg.Flags)
base.EncapType = msg.EncapType()
if msg.Flags&unix.IFF_PROMISC != 0 { if msg.Flags&unix.IFF_PROMISC != 0 {
base.Promisc = 1 base.Promisc = 1
} }