Properly skip tests which require root.

All these tests currently fail with 'Operation not permitted' when run as
non-root.
This commit is contained in:
Sebastien Boving 2017-02-06 08:14:07 -08:00 committed by Vish Ishaya
parent e0c5e75bb2
commit dbc72376c8
5 changed files with 14 additions and 1 deletions

View File

@ -39,6 +39,8 @@ func TestHandleCreateDelete(t *testing.T) {
}
func TestHandleCreateNetns(t *testing.T) {
skipUnlessRoot(t)
id := make([]byte, 4)
if _, err := io.ReadFull(rand.Reader, id); err != nil {
t.Fatal(err)
@ -236,6 +238,7 @@ func parallelDone() {
// Do few route and xfrm operation on the two handles in parallel
func runParallelTests(t *testing.T, thread int) {
skipUnlessRoot(t)
defer parallelDone()
t.Parallel()

View File

@ -862,6 +862,8 @@ func TestLinkSubscribe(t *testing.T) {
}
func TestLinkSubscribeAt(t *testing.T) {
skipUnlessRoot(t)
// Create an handle on a custom netns
newNs, err := netns.New()
if err != nil {

View File

@ -11,12 +11,16 @@ import (
type tearDownNetlinkTest func()
func setUpNetlinkTest(t *testing.T) tearDownNetlinkTest {
func skipUnlessRoot(t *testing.T) {
if os.Getuid() != 0 {
msg := "Skipped test because it requires root privileges."
log.Printf(msg)
t.Skip(msg)
}
}
func setUpNetlinkTest(t *testing.T) tearDownNetlinkTest {
skipUnlessRoot(t)
// new temporary namespace so we don't pollute the host
// lock thread since the namespace is thread local

View File

@ -208,6 +208,8 @@ func TestRouteSubscribe(t *testing.T) {
}
func TestRouteSubscribeAt(t *testing.T) {
skipUnlessRoot(t)
// Create an handle on a custom netns
newNs, err := netns.New()
if err != nil {

View File

@ -7,6 +7,8 @@ import (
)
func TestRuleAddDel(t *testing.T) {
skipUnlessRoot(t)
srcNet := &net.IPNet{IP: net.IPv4(172, 16, 0, 1), Mask: net.CIDRMask(16, 32)}
dstNet := &net.IPNet{IP: net.IPv4(172, 16, 1, 1), Mask: net.CIDRMask(24, 32)}