RepoMirrors/netlink
1
0
Fork 0
mirror of https://github.com/vishvananda/netlink synced 2025-04-01 00:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure bond settings are populated correctly

Browse Source 
Currently a LinkByName("bondX") doesn't return the bond specific attributes.

parseBondData needs to update the link that is passed in in order for
the bond's Mode, Miimon etc to be populated correctly.
This commit is contained in:
Stuart McLaren 2017-04-10 16:18:05 +01:00 committed by Vish Ishaya
parent b7148c6755
commit 40e43c1d63
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
link_linux.go
View File

@ -1370,7 +1370,7 @@ func parseVxlanData(link Link, data []syscall.NetlinkRouteAttr) {
}
func parseBondData(link Link, data []syscall.NetlinkRouteAttr) {
bond := NewLinkBond(NewLinkAttrs())
bond := link.(*Bond)
for i := range data {
switch data[i].Attr.Type {
case nl.IFLA_BOND_MODE:

14
link_test.go
View File

@ -128,6 +128,16 @@ func testLinkAddDel(t *testing.T, link Link) {
}
}
if bond, ok := link.(*Bond); ok {
other, ok := result.(*Bond)
if !ok {
t.Fatal("Result of create is not a bond")
}
if bond.Mode != other.Mode {
t.Fatalf("Got unexpected mode: %d, expected: %d", other.Mode, bond.Mode)
}
}
if _, ok := link.(*Iptun); ok {
_, ok := result.(*Iptun)
if !ok {
@ -335,7 +345,9 @@ func TestLinkAddDelBond(t *testing.T) {
tearDown := setUpNetlinkTest(t)
defer tearDown()
testLinkAddDel(t, NewLinkBond(LinkAttrs{Name: "foo"}))
bond := NewLinkBond(LinkAttrs{Name: "foo"})
bond.Mode = StringToBondModeMap["802.3ad"]
testLinkAddDel(t, bond)
}
func TestLinkAddVethWithDefaultTxQLen(t *testing.T) {