diff --git a/addr_test.go b/addr_test.go index 413523c..1735b83 100644 --- a/addr_test.go +++ b/addr_test.go @@ -6,93 +6,34 @@ import ( "testing" ) -func TestAddrAddDel(t *testing.T) { - tearDown := setUpNetlinkTest(t) - defer tearDown() - - link, err := LinkByName("lo") - if err != nil { - t.Fatal(err) - } - - addr, err := ParseAddr("127.1.1.1/24 local") - if err != nil { - t.Fatal(err) - } - - if err = AddrAdd(link, addr); err != nil { - t.Fatal(err) - } - - addrs, err := AddrList(link, FAMILY_ALL) - if err != nil { - t.Fatal(err) - } - - if len(addrs) != 1 || !addr.Equal(addrs[0]) || addrs[0].Label != addr.Label { - t.Fatal("Address not added properly") - } - - if err = AddrDel(link, addr); err != nil { - t.Fatal(err) - } - addrs, err = AddrList(link, FAMILY_ALL) - if err != nil { - t.Fatal(err) - } - - if len(addrs) != 0 { - t.Fatal("Address not removed properly") - } -} - -func TestAddrAddDelScope(t *testing.T) { - tearDown := setUpNetlinkTest(t) - defer tearDown() - - link, err := LinkByName("lo") - if err != nil { - t.Fatal(err) - } - - addr := &Addr{ - IPNet: &net.IPNet{ - IP: net.IPv4(127, 1, 1, 1), - Mask: net.CIDRMask(24, 32), +func TestAddr(t *testing.T) { + var address = &net.IPNet{net.IPv4(127, 0, 0, 2), net.CIDRMask(24, 32)} + var addrTests = []struct { + addr *Addr + expected *Addr + }{ + { + &Addr{IPNet: address}, + &Addr{IPNet: address, Label: "lo", Scope: syscall.RT_SCOPE_UNIVERSE, Flags: syscall.IFA_F_PERMANENT}, + }, + { + &Addr{IPNet: address, Label: "local"}, + &Addr{IPNet: address, Label: "local", Scope: syscall.RT_SCOPE_UNIVERSE, Flags: syscall.IFA_F_PERMANENT}, + }, + { + &Addr{IPNet: address, Flags: syscall.IFA_F_OPTIMISTIC}, + &Addr{IPNet: address, Label: "lo", Flags: syscall.IFA_F_OPTIMISTIC | syscall.IFA_F_PERMANENT, Scope: syscall.RT_SCOPE_UNIVERSE}, + }, + { + &Addr{IPNet: address, Flags: syscall.IFA_F_OPTIMISTIC | syscall.IFA_F_DADFAILED}, + &Addr{IPNet: address, Label: "lo", Flags: syscall.IFA_F_OPTIMISTIC | syscall.IFA_F_DADFAILED | syscall.IFA_F_PERMANENT, Scope: syscall.RT_SCOPE_UNIVERSE}, + }, + { + &Addr{IPNet: address, Scope: syscall.RT_SCOPE_NOWHERE}, + &Addr{IPNet: address, Label: "lo", Flags: syscall.IFA_F_PERMANENT, Scope: syscall.RT_SCOPE_NOWHERE}, }, - Scope: syscall.RT_SCOPE_LINK, - } - if err = AddrAdd(link, addr); err != nil { - t.Fatal(err) } - addrs, err := AddrList(link, FAMILY_ALL) - if err != nil { - t.Fatal(err) - } - - if len(addrs) != 1 || !addr.Equal(addrs[0]) { - t.Fatal("Address not added properly") - } - - if addrs[0].Scope != addr.Scope { - t.Fatal("Address scope not added properly") - } - - if err = AddrDel(link, addr); err != nil { - t.Fatal(err) - } - addrs, err = AddrList(link, FAMILY_ALL) - if err != nil { - t.Fatal(err) - } - - if len(addrs) != 0 { - t.Fatal("Address not removed properly") - } -} - -func TestAddrAddDelFlags(t *testing.T) { tearDown := setUpNetlinkTest(t) defer tearDown() @@ -101,39 +42,47 @@ func TestAddrAddDelFlags(t *testing.T) { t.Fatal(err) } - addr := &Addr{ - IPNet: &net.IPNet{ - IP: net.IPv4(127, 1, 1, 1), - Mask: net.CIDRMask(24, 32), - }, - Flags: syscall.IFA_F_PERMANENT, - } - if err = AddrAdd(link, addr); err != nil { - t.Fatal(err) - } + for _, tt := range addrTests { + if err = AddrAdd(link, tt.addr); err != nil { + t.Fatal(err) + } - addrs, err := AddrList(link, FAMILY_ALL) - if err != nil { - t.Fatal(err) - } + addrs, err := AddrList(link, FAMILY_ALL) + if err != nil { + t.Fatal(err) + } - if len(addrs) != 1 || !addr.Equal(addrs[0]) { - t.Fatal("Address not added properly") - } + if len(addrs) != 1 { + t.Fatal("Address not added properly") + } - if addrs[0].Flags != addr.Flags { - t.Fatal("Address flags not set properly") - } + if !addrs[0].Equal(*tt.expected) { + t.Fatalf("Address ip no set properly, got=%s, expected=%s", addrs[0], tt.expected) + } - if err = AddrDel(link, addr); err != nil { - t.Fatal(err) - } - addrs, err = AddrList(link, FAMILY_ALL) - if err != nil { - t.Fatal(err) - } + if addrs[0].Label != tt.expected.Label { + t.Fatalf("Address label not set properly, got=%s, expected=%s", addrs[0].Label, tt.expected.Label) + } - if len(addrs) != 0 { - t.Fatal("Address not removed properly") + if addrs[0].Flags != tt.expected.Flags { + t.Fatalf("Address flags not set properly, got=%d, expected=%d", addrs[0].Flags, tt.expected.Flags) + } + + if addrs[0].Scope != tt.expected.Scope { + t.Fatalf("Address scope not set properly, got=%d, expected=%d", addrs[0].Scope, tt.expected.Scope) + } + + if err = AddrDel(link, tt.addr); err != nil { + t.Fatal(err) + } + + addrs, err = AddrList(link, FAMILY_ALL) + if err != nil { + t.Fatal(err) + } + + if len(addrs) != 0 { + t.Fatal("Address not removed properly") + } } }