Commit Graph

2073 Commits

Author SHA1 Message Date
rofl0r
526900484c arm: add __aeabi_atexit()
arm eabi requires this symbol for static C++ dtors.
usually it is provided by libstdc++, but when a C++ program
doesn't use the std lib (free-standing), the libc has to provide
it.
this was encountered while building transmission, which
depends on such a C++ library (libutp).

this function is nearly identical to __cxa_atexit, but it has the
order of argumens swapped for "performance reasons".
see page 25 of

 http://infocenter.arm.com/help/topic/com.arm.doc.ihi0043d/IHI0043D_rtabi.pdf

there are other aeabi specific C++ support functions missing, but
it is not clear yet that GCC makes use of them so we omit them for
the moment.
2013-02-06 22:46:19 +01:00
rofl0r
158f721adc Makefile: make it possible to build arch specific C files 2013-02-06 02:40:22 +01:00
Rich Felker
a8799356d5 base system() on posix_spawn
this avoids duplicating the fragile logic for executing an external
program without fork.
2013-02-03 18:21:04 -05:00
Rich Felker
4862864fc1 fix unsigned comparison bug in posix_spawn
read should never return anything but 0 or sizeof ec here, but if it
does, we want to treat any other return as "success". then the caller
will get back the pid and is responsible for waiting on it when it
immediately exits.
2013-02-03 17:09:47 -05:00
Rich Felker
fb6b159d9e overhaul posix_spawn to use CLONE_VM instead of vfork
the proposed change was described in detail in detail previously on
the mailing list. in short, vfork is unsafe because:

1. the compiler could make optimizations that cause the child to
clobber the parent's local vars.

2. strace is buggy and allows the vforking parent to run before the
child execs when run under strace.

the new design uses a close-on-exec pipe instead of vfork semantics to
synchronize the parent and child so that the parent does not return
before the child has finished using its arguments (and now, also its
stack). this also allows reporting exec failures to the caller instead
of giving the caller a child that mysteriously exits with status 127
on exec error.

basic testing has been performed on both the success and failure code
paths. further testing should be done.
2013-02-03 16:42:40 -05:00
Rich Felker
89d3df6e54 streamline old-kernel fallback path of pipe2 to use syscalls directly
also, don't waste code/time on F_GETFL since pipes always have blank
flags initially (at least on old kernels, which are all this fallback
code matters for).
2013-02-03 16:09:05 -05:00
Rich Felker
d432b2c057 fix regression that made shared libs crash on arm 2013-02-03 01:26:33 -05:00
Rich Felker
a47ad3ebce dynamically allocate storage for gethostby* buffers
this change shaves ~1k off libc.so bss size, and also avoids hard
errors in the case where the static buffer was not large enough to
hold the result.

this whole framework is really ugly and might should be replaced or at
least heavily overhauled when some changes/factorizations are made to
getaddrinfo internals in the future.
2013-02-02 02:07:38 -05:00
Rich Felker
c0193550a0 fix blank ai_canonname from getaddrinfo for non-CNAMEs 2013-02-02 01:59:53 -05:00
Rich Felker
b0302863a3 fix memory leak due to double call to getaddrinfo in gethostbyname* 2013-02-02 01:32:12 -05:00
Rich Felker
70b584bc94 fix error returns in gethostby*_r functions
they're supposed to return an error code rather than using errno.
2013-02-02 01:31:10 -05:00
Rich Felker
74025c80ce fix uninitialized map_len being used in munmap failure paths in load_library
this bug seems to have been introduced when the map_library signatures
was changed to return the mapping in a temp dso structure instead of
into separate variables.
2013-02-02 00:59:25 -05:00
Rich Felker
72768ea99e fix stale locks left behind when pthread_create fails
this bug seems to have been around a long time.
2013-02-01 22:25:19 -05:00
Rich Felker
077549e0d4 if pthread_create fails, it must not attempt mmap if there is no mapping
this bug was introduced when support for application-provided stacks
was originally added.
2013-02-01 22:23:24 -05:00
Rich Felker
d5142642b8 pthread stack treatment overhaul for application-provided stacks, etc.
the main goal of these changes is to address the case where an
application provides a stack of size N, but TLS has size M that's a
significant portion of the size N (or even larger than N), thus giving
the application less stack space than it expected or no stack at all!

the new strategy pthread_create now uses is to only put TLS on the
application-provided stack if TLS is smaller than 1/8 of the stack
size or 2k, whichever is smaller. this ensures that the application
always has "close enough" to what it requested, and the threshold is
chosen heuristically to make sure "sane" amounts of TLS still end up
in the application-provided stack.

if TLS does not fit the above criteria, pthread_create uses mmap to
obtain space for TLS, but still uses the application-provided stack
for actual call frame stack. this is to avoid wasting memory, and for
the sake of supporting ugly hacks like garbage collection based on
assumptions that the implementation will use the provided stack range.

in order for the above heuristics to ever succeed, the amount of TLS
space wasted on POSIX TSD (pthread_key_create based) needed to be
reduced. otherwise, these changes would preclude any use of
pthread_create without mmap, which would have serious memory usage and
performance costs for applications trying to create huge numbers of
threads using pre-allocated stack space. the new value of
PTHREAD_KEYS_MAX is the minimum allowed by POSIX, 128. this should
still be plenty more than real-world applications need, especially now
that C11/gcc-style TLS is now supported in musl, and most apps and
libraries choose to use that instead of POSIX TSD when available.

at the same time, PTHREAD_STACK_MIN has been decreased. it was
originally set to PAGE_SIZE back when there was no support for TLS or
application-provided stacks, and requests smaller than a whole page
did not make sense. now, there are two good reasons to support
requests smaller than a page: (1) applications could provide
pre-allocated stacks smaller than a page, and (2) with smaller stack
sizes, stack+TLS+TSD can all fit in one page, making it possible for
applications which need huge numbers of threads with minimal stack
needs to allocate exactly one page per thread. the new value of
PTHREAD_STACK_MIN, 2k, is aligned with the minimum size for
sigaltstack.
2013-02-01 22:10:40 -05:00
rofl0r
c50925071c make some arrays const
this way they'll go into .rodata, decreasing memory pressure.
2013-02-02 03:19:25 +01:00
Rich Felker
facc6acbfd replace __wake function with macro that performs direct syscall
this should generate faster and smaller code, especially with inline
syscalls. the conditional with cnt is ugly, but thankfully cnt is
always a constant anyway so it gets evaluated at compile time. it may
be preferable to make separate __wake and __wakeall macros without a
count argument.

priv flag is not used yet; private futex support still needs to be
done at some point in the future.
2013-02-01 16:41:53 -05:00
Rich Felker
96fbcf7d80 fix up minor misplacement of restrict keyword in spawnattr sched stubs 2013-02-01 15:57:28 -05:00
Rich Felker
a57ac9bf64 release notes for 0.9.9 2013-02-01 01:49:07 -05:00
Rich Felker
ae4b0b96d6 revert regex "cleanup" that seems unjustified and may break backtracking
it's not clear to me at the moment whether the code that was removed
(and which is now being re-added) is needed, but it's far from being a
no-op, and i don't want to risk breaking regex in this release.
2013-02-01 01:10:59 -05:00
Rich Felker
725c55528d SOL_TCP is nonstandard and not in the reserved namespace
alternatively, we could define it in sys/socket.h since SO* is
reserved there, and tcp.h includes sys/socket.h in extensions mode.

note that SOL_TCP is simply wrong and it's only here for compatibility
with broken applications. the correct argument to pass for setting TCP
socket options is IPPROTO_TCP, which of course has the same value as
SOL_TCP but works everywhere.
2013-01-31 00:49:53 -05:00
Rich Felker
d5c164d5ff fix tm_to_time logic for number of days in november
report/patch by Hiltjo Posthuma <hiltjo@codemadness.org>
2013-01-26 11:40:40 -05:00
Rich Felker
55ddbc3e5d add RTLD_NODELETE flag for dlopen
this is a trivial no-op, because dlclose never deletes libraries. thus
we might as well have it in the header in case some application wants
it, since we're already providing it anyway.
2013-01-23 22:18:45 -05:00
Rich Felker
4d07e5521e add support for RTLD_NOLOAD to dlopen
based on patch by Pierre Carrier <pierre@gcarrier.fr> that just added
the flag constant, but with minimal additional code so that it
actually works as documented. this is a nonstandard option but some
major software (reportedly, Firefox) uses it and it was easy to add
anyway.
2013-01-23 22:07:45 -05:00
Rich Felker
637dd2d383 fix regression in dlsym: rejection of special RTLD_* handles as invalid 2013-01-23 20:21:36 -05:00
Rich Felker
41d7c77d6a use a common definition of NULL as 0L for C and C++
the historical mess of having different definitions for C and C++
comes from the historical C definition as (void *)0 and the fact that
(void *)0 can't be used in C++ because it does not convert to other
pointer types implicitly. however, using plain 0 in C++ exposed bugs
in C++ programs that call variadic functions with NULL as an argument
and (wrongly; this is UB) expect it to arrive as a null pointer. on
64-bit machines, the high bits end up containing junk. glibc dodges
the issue by using a GCC extension __null to define NULL; this is
observably non-conforming because a conforming application could
observe the definition of NULL via stringizing and see that it is
neither an integer constant expression with value zero nor such an
expression cast to void.

switching to 0L eliminates the issue and provides compatibility with
broken applications, since on all musl targets, long and pointers have
the same size, representation, and argument-passing convention. we
could maintain separate C and C++ definitions of NULL (i.e. just use
0L on C++ and use (void *)0 on C) but after careful analysis, it seems
extremely difficult for a C program to even determine whether NULL has
integer or pointer type, much less depend in subtle, unintentional
ways, on whether it does. C89 seems to have no way to make the
distinction. on C99, the fact that (int)(void *)0 is not an integer
constant expression, along with subtle VLA/sizeof semantics, can be
used to make the distinction, but many compilers are non-conforming
and give the wrong result to this test anyway. on C11, _Generic can
trivially make the distinction, but it seems unlikely that code
targetting C11 would be so backwards in caring which definition of
NULL an implementation uses.

as such, the simplest path of using the same definition for NULL in
both C and C++ was chosen. the #undef directive was also removed so
that the compiler can catch and give a warning or error on
redefinition if buggy programs have defined their own versions of
NULL prior to inclusion of standard headers.
2013-01-18 20:35:26 -05:00
Rich Felker
4d98280388 fix warning building dynlink.c stub for static libc
struct dso was not defined in this case, and it's not needed in the
code that was using it anyway; void pointers work just as well.
2013-01-16 11:49:00 -05:00
Rich Felker
cdc5c74c6a fix bug in dladdr that prevented resolving addresses in the PLT 2013-01-16 11:47:35 -05:00
Szabolcs Nagy
f05f59b804 remove unused "params" related code from regex
some structs and functions had reference to the params
feature of tre that is not used by the code anymore
2013-01-15 01:05:29 +01:00
Rich Felker
21f01e1bf9 Merge remote-tracking branch 'nsz/math' 2013-01-14 18:04:49 -05:00
Szabolcs Nagy
dd95916382 regex: remove an unused local variable from regexec
pos_start local variable is not used in tre_tnfa_run_backtrack
2013-01-14 00:06:49 +01:00
Szabolcs Nagy
9724defdb7 in crypt_des change unnecessary union keybuf into unsigned char[]
original FreeSec code accessed keybuf as uint32* and uint8* as well
(incorrectly), this got fixed with an union, but then it seems the
uint32* access is no longer needed so the code can be simplified
2013-01-13 23:54:48 +01:00
Szabolcs Nagy
30779ee1aa crypt: fix the prototype of md5_sum, sha256_sum and sha512_sum
the internal sha2 hash sum functions had incorrect array size
in the prototype for the message digest argument, fixed by
using pointer so it is not misleading
2013-01-13 23:18:32 +01:00
Szabolcs Nagy
a753f7fe7a fix lio_listio return value in LIO_WAIT mode 2013-01-13 23:15:39 +01:00
Szabolcs Nagy
200f96c6a0 add MOD_TAI to sys/timex.h and update STA_RONLY 2013-01-12 19:42:39 +01:00
Szabolcs Nagy
d650631dad add SWAP_FLAG_DISCARD to sys/swap.h 2013-01-12 19:42:39 +01:00
Szabolcs Nagy
645c6d99a5 add mount flags to sys/mount.h
added various MS_*, MNT_*, UMOUNT_* flags following the linux
headers, with one exception: MS_NOUSER is defined as (1U<<31)
instead of (1<<31) which invokes undefined behaviour

the S_* flags were removed following glibc
2013-01-12 19:42:39 +01:00
Szabolcs Nagy
48854dffdb add IN_EXCL_UNLINK to sys/inotify.h 2013-01-12 19:42:39 +01:00
Szabolcs Nagy
ada88f6178 add EPOLLWAKEUP flag to sys/epoll.h 2013-01-12 19:42:39 +01:00
Szabolcs Nagy
c7351ffe9b add RB_SW_SUSPEND and RB_KEXEC to sys/reboot.h
using the glibc names for the magic constants of the linux reboot syscall
2013-01-12 19:42:39 +01:00
Szabolcs Nagy
000806cde6 add missing mmap options and madvices to bits/mman.h based on linux headers 2013-01-12 19:42:39 +01:00
Szabolcs Nagy
bc1a8d2ae3 add missing EXTPROC flag to bits/termios.h
mips and powerpc already had this termios flag defined
2013-01-12 19:42:39 +01:00
Szabolcs Nagy
73bb048951 add missing F_GETOWNER_UIDS flag to bits/fcntl.h 2013-01-12 19:42:39 +01:00
Szabolcs Nagy
056c8b1ab5 add missing EHWPOISON to bits/errno.h
it was already defined for mips, but was missing from other archs
2013-01-12 19:42:39 +01:00
Szabolcs Nagy
2010361663 add missing ptrace requests and options to sys/ptrace.h 2013-01-12 19:42:39 +01:00
Szabolcs Nagy
119645b6bb add missing multicast socket options to netinet/in.h
based on linux headers add the missing MCAST_* options
under _GNU_SOURCE as they are not in the reserved namespace
(this api was originally specified by RFC 3678)
2013-01-12 19:42:39 +01:00
Szabolcs Nagy
f13a478860 add missing protocol families to sys/socket.h
missing protocol families based on current linux headers:
PF_RDS, PF_LLC, PF_CAN, PF_TIPC, PF_NFC
2013-01-12 19:42:38 +01:00
Rich Felker
2dec29741b fix another case of cloexec/nonblock flags not matching arch values 2013-01-10 17:57:30 -05:00
Rich Felker
6468fc9e37 check for invalid handles in dlsym/dlclose
this is wasteful and useless from a standpoint of sane programs, but
it is required by the standard, and the current requirements were
upheld with the closure of Austin Group issue #639:
http://austingroupbugs.net/view.php?id=639
2013-01-10 14:05:40 -05:00
Szabolcs Nagy
121e3a38a1 math: erf and erfc cleanup
common part of erf and erfc was put in a separate function which
saved some space and the new code is using unsigned arithmetics

erfcf had a bug: for some inputs in [7.95,8] the result had
more than 60ulp error: in expf(-z*z - 0.5625f) the argument
must be exact but not enough lowbits of z were zeroed,
-SET_FLOAT_WORD(z, ix&0xfffff000);
+SET_FLOAT_WORD(z, ix&0xffffe000);
fixed the issue
2013-01-07 23:54:13 +01:00