Commit Graph

6 Commits

Author SHA1 Message Date
Alex Dowad
1b0c9cd099 recognize partial register operands in i386 CFI generation 2015-10-13 18:02:36 -04:00
Alex Dowad
8cfdfa9c8f fix misinterpretation of indexed memory operand in i386 CFI generation
a register used as an index in the memory destination of a mov
instruction was wrongly interpreted as the destination of the mov.
2015-10-13 17:58:43 -04:00
Alex Dowad
fef9c801fe fix misinterpretation of operand order in i386 CFI generation
binary ops like ADD, AND, etc. modify the 2nd operand, not 1st.
2015-10-13 17:21:05 -04:00
Alex Dowad
dc97951402 fix instruction matching errors in i386 CFI generation
fdiv and fmul instructions were wrongly matched by the rules for
integer div and mul instructions, leading to incorrect conclusions
about register values being clobbered.
2015-10-08 21:04:41 +00:00
Alex Dowad
0650a05947 factor common awk functions for CFI generation scripts into new file
There is a lot which could be common between i386 and x86_64, but none
of it will be useful for any other arch. These should be useful for
all archs, however.
2015-10-08 21:03:10 +00:00
Alex Dowad
35b3312b6f Build process uses script to add CFI directives to x86 asm
Some functions implemented in asm need to use EBP for purposes other
than acting as a frame pointer. (Notably, it is used for the 6th
argument to syscalls with 6 arguments.) Without frame pointers, GDB
can only show backtraces if it gets CFI information from a
.debug_frame or .eh_frame ELF section.

Rather than littering our asm with ugly .cfi directives, use an awk
script to insert them in the right places during the build process, so
GDB can keep track of where the current stack frame is relative to the
stack pointer. This means GDB can produce beautiful stack traces at
any given point when single-stepping through asm functions.

Additionally, when registers are saved on the stack and later
overwritten, emit ..cfi directives so GDB will know where they were
saved relative to the stack pointer. This way, when you look back up
the stack from within an asm function, you can still reliably print
the values of local variables in the caller.

If this awk script were to understand every possible wild and crazy
contortion that an asm programmer can do with the stack and registers,
and always emit the exact ..cfi directives needed for GDB to know what
the register values were in the preceding stack frame, it would
necessarily be as complex as a full x86 emulator. That way lies
madness.

Hence, we assume that the stack pointer will _only_ ever be adjusted
using push/pop or else add/sub with a constant. We do not attempt to
detect every possible way that a register value could be saved for
later use, just the simple and common ways.

Thanks to Szabolcs Nagy for suggesting numerous improvements to this
code.
2015-08-26 14:55:13 +00:00