Commit Graph

2134 Commits

Author SHA1 Message Date
Rich Felker
38e6acbf89 stdbool.h should define __bool_true_false_are_defined even for C++
while the incorporation of this requirement from C99 into C++11 was
likely an accident, some software expects it to be defined, and it
doesn't hurt. if the requirement is removed, then presumably
__bool_true_false_are_defined would just be in the implementation
namespace and thus defining it would still be legal.
2013-08-28 00:41:00 -04:00
Rich Felker
ebc87349fe fix invalid instruction mnemonics in powerpc fenv asm
there is no non-dot version of the andis instruction, but there's no
harm in updating the flags anyway, so just use the dot version.
2013-08-27 18:54:46 -04:00
Rich Felker
a543369e3b optimized C memset
this version of memset is optimized both for small and large values of
n, and makes no misaligned writes, so it is usable (and near-optimal)
on all archs. it is capable of filling up to 52 or 56 bytes without
entering a loop and with at most 7 branches, all of which can be fully
predicted if memset is called multiple times with the same size.

it also uses the attribute extension to inform the compiler that it is
violating the aliasing rules, unlike the previous code which simply
assumed it was safe to violate the aliasing rules since translation
unit boundaries hide the violations from the compiler. for non-GNUC
compilers, 100% portable fallback code in the form of a naive loop is
provided. I intend to eventually apply this approach to all of the
string/memory functions which are doing word-at-a-time accesses.
2013-08-27 18:08:29 -04:00
Rich Felker
06ceee8ca3 add attribute((may_alias)) checking in configure
this will be needed for upcoming commits to the string/mem functions
to correct their unannounced use of aliasing violations for
word-at-a-time search, fill, and copy operations.
2013-08-27 17:33:47 -04:00
Rich Felker
242a4bb440 add the %s (seconds since the epoch) format to strftime
this is a nonstandard extension but will be required in the next
version of POSIX, and it's widely used/useful in shell scripts
utilizing the date utility.
2013-08-25 02:02:15 -04:00
Rich Felker
2828a130b1 fix strftime regression in %e format
%e pads with spaces instead of zeros.
2013-08-24 14:35:17 -04:00
Rich Felker
190bbb9923 properly fill in tzname[] for old (pre-64-bit-format) zoneinfo files
in this case, the first standard-time and first daylight-time rules
should be taken as the "default" ones to expose.
2013-08-24 13:11:18 -04:00
Rich Felker
32985d4f63 minor fix to tz name checking
if a zoneinfo file is not (or is no longer) in use, don't check the
abbrevs pointers, which may be invalid.
2013-08-24 13:10:01 -04:00
Rich Felker
d78be392e1 fix strftime handling of time zone data
this may need further revision in the future, since POSIX is rather
unclear on the requirements, and is designed around the assumption of
POSIX TZ specifiers which are not sufficiently powerful to represent
real-world timezones (this is why zoneinfo support was added).

the basic issue is that strftime gets the string and numeric offset
for the timezone from the extra fields in struct tm, which are
initialized when calling localtime/gmtime/etc. however, a conforming
application might have created its own struct tm without initializing
these fields, in which case using __tm_zone (a pointer) could crash.
other zoneinfo-based implementations simply check for a null pointer,
but otherwise can still crash of the field contains junk.

simply ignoring __tm_zone and using tzname[] would "work" but would
give incorrect results in time zones with more complex rules. I feel
like this would lower the quality of implementation.

instead, simply validate __tm_zone: unless it points to one of the
zone name strings managed by the timezone system, assume it's invalid.

this commit also fixes several other minor bugs with formatting:
tm_isdst being negative is required to suppress printing of the zone
formats, and %z was using the wrong format specifiers since the type
of val was changed, resulting in bogus output.
2013-08-24 12:59:02 -04:00
Rich Felker
0f9b1f672b make dlopen honor the rpath of the main program
this seems to match what other systems do, and seems useful for
programs that have their libraries and plugins stored relative to the
executable.
2013-08-23 23:13:25 -04:00
Rich Felker
bd5ed22c58 fix mishandling of empty or blank TZ environment variable
the empty TZ string was matching equal to the initial value of the
cached TZ name, thus causing do_tzset never to run and never to
initialize the time zone data.
2013-08-23 23:07:09 -04:00
Rich Felker
7211551e9f fix regression in dn_expand/reverse dns
off-by-one error copying the name components was yielding junk at the
beginning and truncating one character at the end (of every
component).
2013-08-23 21:25:01 -04:00
Rich Felker
d2c42ed25f fix bugs in $ORIGIN handling
1. an occurrence of ${ORIGIN} before $ORIGIN would be ignored due to
the strstr logic. (note that rpath contains multiple :-delimited paths
to be searched.)

2. data read by readlink was not null-terminated.
2013-08-23 15:51:59 -04:00
Rich Felker
cc51505a32 use AT_EXECFN, if available, for dynamic linker to identify main program
fallback to argv[0] as before. unlike argv[0], AT_EXECFN was a valid
(but possibly relative) pathname for the new program image at the time
the execve syscall was made.

as a special case, ignore AT_EXECFN if it begins with "/proc/", in
order not to give bogus (and possibly harmful) results when fexecve
was used.
2013-08-23 14:14:47 -04:00
Rich Felker
a897a20a57 add rpath $ORIGIN processing to dynamic linker 2013-08-23 13:56:30 -04:00
Rich Felker
709355e1f6 add recursive rpath support to dynamic linker
previously, rpath was only honored for direct dependencies. in other
words, if A depends on B and B depends on C, only B's rpath (if any),
not A's rpath, was being searched for C. this limitation made
rpath-based deployment difficult in the presence of multiple levels of
library dependency.

at present, $ORIGIN processing in rpath is still unsupported.
2013-08-23 11:15:40 -04:00
Rich Felker
8b491f1499 fix missing string.h in strftime.c (needed by new strftime code)
this bug was masked by local experimental CFLAGS in my config.mak.
2013-08-23 08:11:43 -04:00
Rich Felker
6fdaaf251d fix some documentation typos 2013-08-22 22:40:30 -04:00
Rich Felker
fc48ceee77 add strftime and wcsftime field widths
at present, since POSIX requires %F to behave as %+4Y-%m-%d and ISO C
requires %F to behave as %Y-%m-%d, the default behavior for %Y has
been changed to match %+4Y. this seems to be the only way to conform
to the requirements of both standards, and it does not affect years
prior to the year 10000. depending on the outcome of interpretations
from the standards bodies, this may be adjusted at some point.
2013-08-22 22:36:19 -04:00
Rich Felker
33413cdd25 simplify strftime and fix integer overflows
use a long long value so that even with offsets, values cannot
overflow. instead of using different format strings for different
numeric formats, simply use a per-format width and %0*lld for all of
them.

this width specifier is not for use with strftime field widths; that
will be a separate step in the caller.
2013-08-22 19:44:02 -04:00
Rich Felker
87e133b352 strftime cleanup: avoid recomputing strlen when it's known 2013-08-22 19:36:30 -04:00
Rich Felker
45849d3dcb more strftime refactoring
make __strftime_fmt_1 return a string (possibly in the caller-provided
temp buffer) rather than writing into the output buffer. this approach
makes more sense when padding to a minimum field width might be
required, and it's also closer to what wcsftime wants.
2013-08-22 19:27:36 -04:00
Rich Felker
f5e4efc4bd begin refactoring strftime to make adding field widths easier 2013-08-22 19:02:52 -04:00
Rich Felker
ecf4e24d81 add SUN_LEN macro to sys/un.h under appropriate feature tests
this is ugly and useless, but it seems to be the least-ugly way to
provide it...
2013-08-21 21:46:57 -04:00
Rich Felker
580b8d8c52 unbreak vwarn: print ": " before errno message
patch by Strake. this seems to be a regression caused by fixing the
behavior of perror("") to match perror(0) at some point in the past.
2013-08-21 00:49:46 -04:00
Rich Felker
e449974dc5 fix two bugs in sed code configure uses to save command line
one place where semicolon (non-portable) was still used in place of
separate -e options (copied over from an old version of this code),
and use of a literal slash in the bracket expression for the final
command, despite slash being used as the delimiter for the s command.
2013-08-20 13:51:46 -04:00
Rich Felker
4681aae23a re-add logic for ignoring failure of ld.so symlink installation
this was inadvertently removed when switching to the new install.sh.
2013-08-18 20:20:08 -04:00
Szabolcs Nagy
a6b0170a7f fix fenv exception functions to mask their argument
fesetround.c is a wrapper to do the arch independent argument
check (on archs where rounding mode is not stored in 2 bits
__fesetround still has to check its arguments)

on powerpc fe*except functions do not accept the extra invalid
flags of its fpscr register

the useless FENV_ACCESS pragma was removed from feupdateenv
2013-08-18 20:08:18 +00:00
Szabolcs Nagy
d8764bf840 optimize x86 feclearexcept: only use save/restore x87 fenv if needed
the x87 exception summary (ES) and stack fault (SF) flags may be
spuriously cleared by feclearexcept using the fnclex instruction,
but these flags are not observable through libc hence maintaining
their state is not critical.
2013-08-18 16:27:21 +00:00
Szabolcs Nagy
baba2630c9 remove the __mxcsr member from fenv_t on i386 to follow the glibc abi
in the previous commit sse fenv support was added, but there is no
need to save mxcsr (sse fenv register) so fix the abi incompatibility
with glibc.
2013-08-18 16:27:20 +00:00
Szabolcs Nagy
ebc10fa176 add sse fenv support on i386 through hwcap
the sse and x87 rounding modes should be always the same,
the visible exception flags are the bitwise or of the two
fenv states (so it's enough to query the rounding mode or
raise exceptions on one fenv)
2013-08-18 16:27:20 +00:00
Szabolcs Nagy
d684149910 fix i386 fesetenv: FE_DFL_ENV is (fenv_t*)-1 not 0 2013-08-18 16:27:20 +00:00
Rich Felker
37c25065be remove spurious tmp file present since initial git check-in 2013-08-17 22:28:50 -04:00
Rich Felker
e678fc6f32 replace system's install command with a shell script
the historical (non-standardized) install command is really
inappropriate for installing binaries/libraries on a system that
utilizes memory-mapped executable files. rather than replacing an
existing file atomically, it overwrites the existing file. this can
cause running programs to see a partially-modified version of the
file, resulting in unpredictable behavior, or SIGBUS. a MAP_COPY mode
for mmap would get around this problem, but Linux lacks MAP_COPY.

the shell script added with this commit works around the problem by
writing temporary files and moving them into place. unlike the
historical install utility, it also support a -l option for installing
a symbolic link atomically, via the same method.
2013-08-17 22:21:11 -04:00
Rich Felker
109bd65acf add hkscs/big5-2003/eten extensions to iconv big5
with these changes, the character set implemented as "big5" in musl is
a pure superset of cp950, the canonical "big5", and agrees with the
normative parts of Unicode. this means it has minor differences from
both hkscs and big5-2003:

- the range A2CC-A2CE maps to CJK ideographs rather than numerals,
  contrary to changes made in big5-2003.

- C6CD maps to a CJK ideograph rather than its corresponding Kangxi
  radical character, contrary to changes made in hkscs.

- F9FE maps to U+2593 rather than U+FFED.

of these differences, none but the last are visually distinct, and the
last is a character used purely for text-based graphics, not to convey
linguistic content.

should there be future demand for strict conformance to big5-2003 or
hkscs mappings, the present charset aliases can be replaced with
distinct variants.

reportedly there are other non-standard big5 extensions in common use
in Taiwan and perhaps elsewhere, which could also be added as layers
on top of the existing big5 support.

there may be additional characters which should be added to the hkscs
table: the whatwg standard for big5 defines what appears to be a
superset of hkscs.
2013-08-17 16:23:22 -04:00
Rich Felker
453f462297 make configure store its command line in config.mak for easy re-run
proper shell quoting and pretty-printing (avoiding ugly gratuitous
quoting and bad quoting style) is included.
2013-08-16 18:19:47 -04:00
Rich Felker
82fa6b43b3 fix atomicity and other issues installing dynamic linker symlink
ln -sf is non-atomic; it unlinks the destination first. instead, make
a temporary link and rename it into place.

this commit also fixes some of the dependency tracking behavior for
the link. depending on the directory it's to be installed in is not
reasonable; it causes a new link to be attempted if the library
directory has been modified, but does not attempt to make a new link
just because libc has been updated. instead, depend on the target to
be linked to. this will ensure that, if prefix has changed but
syslibdir has not, the link will be updated to point to the new
prefix.
2013-08-16 17:51:38 -04:00
Rich Felker
63893d3ff1 some initial math asm for armhf (fabs[f] and sqrt[f]) 2013-08-16 17:32:30 -04:00
Rich Felker
4918c2bb20 fix detection of arm hardfloat
it turns out that __SOFTFP__ does not indicate the ABI in use but
rather that fpu instructions are not to be used at all. this is
specified in ARM's documentation so I'm unclear on how I previously
got the wrong idea. unfortunately, this resulted in the 0.9.12 release
producing a dynamic linker with the wrong name. fortunately, there do
not yet seem to be any public toolchain builds using the wrong name.

the __ARM_PCS_VFP macro does not seem to be official from ARM, and in
fact it was missing from the very earliest gcc versions (around 4.5.x)
that added -mfloat-abi=hard. it would be possible on such versions to
perform some ugly linker-based tests instead in hopes that the linker
will reject ABI-mismatching object files, if there is demand for
supporting such versions. I would probably prefer to document which
versions are broken and warn users to manually add -D__ARM_PCS_VFP if
using such a version.

there's definitely an argument to be made that the fenv macros should
be exposed even in -mfloat-abi=softfp mode. for now, I have chosen not
to expose them in this case, since the math library will not
necessarily have the capability to raise exceptions (it depends on the
CFLAGS used to compile it), and since exceptions are officially
excluded from the ARM EABI, which the plain "arm" arch aims to
follow.
2013-08-16 17:09:07 -04:00
Rich Felker
7318c62e64 support floating point environment (fenv) on armhf (hard float) subarchs
patch by nsz. I've tested it on an armhf machine and it seems to be
working correctly.
2013-08-16 12:30:37 -04:00
Rich Felker
0a4a4a7a11 fix build of x86_64 expl assembly
apparently this label change was not carried over when adapting the
changes from the i386 version.
2013-08-16 00:29:32 -04:00
Rich Felker
badaa04acc add function types to arm crt assembly
without these, calls may be resolved incorrectly if the calling code
has been compiled to thumb instead of arm. it's not clear to me at
this point whether crt_arch.h is even working if crt1.c is built as
thumb; this needs testing. but the _init and _fini issues were known
to cause crashes in static-linked apps when libc was built as thumb,
and this commit should fix that issue.
2013-08-15 14:52:27 -04:00
Szabolcs Nagy
c221af9516 math: fix pow(x,-1) to raise underflow properly
if FLT_EVAL_METHOD!=0 check if (double)(1/x) is subnormal and not a
power of 2 (if 1/x is power of 2 then either it is exact or the
long double to double rounding already raised inexact and underflow)
2013-08-15 15:13:24 +00:00
Szabolcs Nagy
411efb3bc6 math: fix i386 atan2.s to raise underflow for subnormal results 2013-08-15 14:18:32 +00:00
Szabolcs Nagy
6d85096f49 math: clean up atan2.c
* remove volatile hacks
* don't care about inexact flag for now (removed all the +-tiny)
* fix atanl to raise underflow properly
* remove signed int arithmetics
* use pi/2 instead of pi_o_2 (gcc generates the same code, which is not
correct, but it does not matter: we mainly care about nearest rounding)
2013-08-15 14:05:19 +00:00
Szabolcs Nagy
31c5fb80b9 math: fix x86 asin, atan, exp, log1p to raise underflow
underflow is raised by an inexact subnormal float store,
since subnormal operations are slow, check the underflow
flag and skip the store if it's already raised
2013-08-15 10:56:57 +00:00
Szabolcs Nagy
1b3973fb43 math: fix x86 expl.s to raise underflow and clean up special case handling 2013-08-15 10:54:56 +00:00
Szabolcs Nagy
c599f4f4d7 math: fix asin, atan, log1p, tanh to raise underflow on subnormal
for these functions f(x)=x for small inputs, because f(0)=0 and
f'(0)=1, but for subnormal values they should raise the underflow
flag (required by annex F), if they are approximated by a polynomial
around 0 then spurious underflow should be avoided (not required by
annex F)

all these functions should raise inexact flag for small x if x!=0,
but it's not required by the standard and it does not seem a worthy
goal, so support for it is removed in some cases.

raising underflow:
- x*x may not raise underflow for subnormal x if FLT_EVAL_METHOD!=0
- x*x may raise spurious underflow for normal x if FLT_EVAL_METHOD==0
- in case of double subnormal x, store x as float
- in case of float subnormal x, store x*x as float
2013-08-15 10:14:46 +00:00
Szabolcs Nagy
cd18dc8525 math: fix tgamma to raise underflow for large negative values 2013-08-15 10:13:02 +00:00
Szabolcs Nagy
f29fea00b5 math: fix pow(0,-inf) to raise divbyzero flag 2013-08-15 10:08:45 +00:00