RepoMirrors/musl
1
0
Fork 0
mirror of git://git.musl-libc.org/musl synced 2025-02-24 06:46:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

re-fix vfprintf temporary buffer logic

Browse Source 
commit b5a8b28915 setup the write buffer
bound pointers for the temporary buffer manually to fix a buffer
overflow issue, but in doing so, caused vfprintf on unbuffered files
never to call __towrite, thereby failing to set the stream orientation
to byte-oriented, failing to clear any prior read mode, and failing to
produce an error when the stream is not writable.

revert the inline setup of the bounds pointers and instead zero them,
so that the underlying fwrite code will call __towrite to set them up.
This commit is contained in:
Rich Felker 2018-08-29 23:45:43 -04:00
parent ddc947eda3
commit f1791f42ef
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/stdio/vfprintf.c
View File

@ -674,9 +674,9 @@ int vfprintf(FILE *restrict f, const char *restrict fmt, va_list ap)
if (f->mode < 1) f->flags &= ~F_ERR;
if (!f->buf_size) {
saved_buf = f->buf;
f->wpos = f->wbase = f->buf = internal_buf;
f->buf = internal_buf;
f->buf_size = sizeof internal_buf;
f->wend = internal_buf + sizeof internal_buf;
f->wpos = f->wbase = f->wend = 0;
}
ret = printf_core(f, fmt, &ap2, nl_arg, nl_type);
if (saved_buf) {