RepoMirrors/musl
1
0
Fork 0
mirror of git://git.musl-libc.org/musl synced 2024-12-14 18:55:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix erroneous return of partial username matches by getspnam[_r]

Browse Source 
when using /etc/shadow (rather than tcb) as its backend, getspnam_r
matched any username starting with the caller-provided string rather
than requiring an exact match. in practice this seems to have affected
only systems where one valid username is a prefix for another valid
username, and where the longer username appears first in the shadow
file.
This commit is contained in:
Rich Felker 2015-01-21 14:26:05 -05:00
parent 63cac4e29a
commit ecb608192a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/passwd/getspnam_r.c
View File

@ -98,7 +98,7 @@ int getspnam_r(const char *name, struct spwd *sp, char *buf, size_t size, struct
pthread_cleanup_push(cleanup, f); pthread_cleanup_push(cleanup, f);
while (fgets(buf, size, f) && (k=strlen(buf))>0) { while (fgets(buf, size, f) && (k=strlen(buf))>0) {
if (skip || strncmp(name, buf, l)) { if (skip || strncmp(name, buf, l) || buf[l]!=':') {
skip = buf[k-1] != '\n'; skip = buf[k-1] != '\n';
continue; continue;
} }