From d2e061a2bd3f7674cfef2e2217e0695419041b5e Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Sun, 4 Sep 2011 21:53:20 -0400 Subject: [PATCH] more fmemopen null termination fixes null termination is only added when current size grows. in update modes, null termination is not added if it does not fit (i.e. it is not allowed to clobber data). these rules make very little sense, but that's how it goes.. --- src/stdio/fmemopen.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/stdio/fmemopen.c b/src/stdio/fmemopen.c index 260d2889..1b054a97 100644 --- a/src/stdio/fmemopen.c +++ b/src/stdio/fmemopen.c @@ -54,9 +54,10 @@ static size_t mwrite(FILE *f, const unsigned char *buf, size_t len) if (len > rem) len = rem; memcpy(c->buf+c->pos, buf, len); c->pos += len; - if (c->pos >= c->len) { + if (c->pos > c->len) { c->len = c->pos; - c->buf[c->len==c->size ? c->len-1 : c->len] = 0; + if (c->len < c->size) c->buf[c->len] = 0; + else if ((f->flags&F_NORD) && c->size) c->buf[c->size-1] = 0; } return len; }