RepoMirrors/musl
1
0
Fork 0
mirror of git://git.musl-libc.org/musl synced 2025-01-10 16:49:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix incorrect use of fabs on long double operand in floatscan.c

Browse Source 
based on patch by Dan Gohman, who caught this via compiler warnings.
analysis by Szabolcs Nagy determined that it's a bug, whereby errno
can be set incorrectly for values where the coercion from long double
to double causes rounding. it seems likely that floating point status
flags may be set incorrectly as a result too.

at the same time, clean up use of preprocessor concatenation involving
LDBL_MANT_DIG, which spuriously depends on it being a single unadorned
decimal integer literal, and instead use the equivalent formulation
2/LDBL_EPSILON. an equivalent change on the printf side was made in
commit bff6095d91.
This commit is contained in:
Rich Felker 2019-10-18 19:56:53 -04:00
parent 2d3083e746
commit bff7895499
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/internal/floatscan.c
View File

@ -33,9 +33,6 @@
#define MASK (KMAX-1)
#define CONCAT2(x,y) x ## y
#define CONCAT(x,y) CONCAT2(x,y)
static long long scanexp(FILE *f, int pok)
{
int c;
@ -301,7 +298,7 @@ static long double decfloat(FILE *f, int c, int bits, int emin, int sign, int po
y -= bias;
if ((e2+LDBL_MANT_DIG & INT_MAX) > emax-5) {
if (fabs(y) >= CONCAT(0x1p, LDBL_MANT_DIG)) {
if (fabsl(y) >= 2/LDBL_EPSILON) {
if (denormal && bits==LDBL_MANT_DIG+e2-emin)
denormal = 0;
y *= 0.5;