RepoMirrors
/
musl
mirror of git://git.musl-libc.org/musl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix faccessat AT_EACCESS path not to leave zombie processes 

I mistakenly assumed that clone without a signal produced processes
that would not become zombies; however, waitpid with __WCLONE is
required to release their pids.
This commit is contained in:
Rich Felker 2013-11-01 17:01:52 -04:00
parent 4ecf33614b
commit 984af5c99e
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/unistd/faccessat.c
View File

@ -1,5 +1,6 @@
#include <unistd.h> #include <unistd.h>
#include <fcntl.h> #include <fcntl.h>
#include <sys/wait.h>
#include "syscall.h" #include "syscall.h"
#include "pthread_impl.h" #include "pthread_impl.h"
@ -32,6 +33,8 @@ int faccessat(int fd, const char *filename, int amode, int flag)
char stack[1024]; char stack[1024];
sigset_t set; sigset_t set;
pid_t pid;
int status;
int ret, p[2]; int ret, p[2];
if (pipe2(p, O_CLOEXEC)) return __syscall_ret(-EBUSY); if (pipe2(p, O_CLOEXEC)) return __syscall_ret(-EBUSY);
@ -39,12 +42,13 @@ int faccessat(int fd, const char *filename, int amode, int flag)
__block_all_sigs(&set); __block_all_sigs(&set);
ret = __clone(checker, stack+sizeof stack, 0, &c); pid = __clone(checker, stack+sizeof stack, 0, &c);
__syscall(SYS_close, p[1]); __syscall(SYS_close, p[1]);
if (ret<0 || __syscall(SYS_read, p[0], &ret, sizeof ret) != sizeof(ret)) if (pid<0 || __syscall(SYS_read, p[0], &ret, sizeof ret) != sizeof(ret))
ret = -EBUSY; ret = -EBUSY;
__syscall(SYS_close, p[0]); __syscall(SYS_close, p[0]);
__syscall(SYS_wait4, pid, &status, __WCLONE, 0);
__restore_sigs(&set); __restore_sigs(&set);