From 8e0b38060d7a9916fc2b5de0dd7c166ef60be9c1 Mon Sep 17 00:00:00 2001 From: Przemyslaw Pawelczyk Date: Mon, 23 Oct 2017 00:07:42 +0200 Subject: [PATCH] fix execvp failing on not-dir entries in PATH. It's better to make execvp continue PATH search on ENOTDIR rather than issuing an error. Bogus entries should not render rest of PATH invalid. Maintainer's note: POSIX seems to require the search to continue like this as part of XBD 8.3 Other Environment Variables. Only errors that conclusively determine non-existence are candidates for continuing; otherwise for consistency we have to report the error. --- src/process/execvp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/process/execvp.c b/src/process/execvp.c index 3a8bbe83..480a85e9 100644 --- a/src/process/execvp.c +++ b/src/process/execvp.c @@ -40,7 +40,7 @@ int __execvpe(const char *file, char *const argv[], char *const envp[]) memcpy(b+(z-p)+(z>p), file, k+1); execve(b, argv, envp); if (errno == EACCES) seen_eacces = 1; - else if (errno != ENOENT) return -1; + else if (errno != ENOENT && errno != ENOTDIR) return -1; if (!*z++) break; } if (seen_eacces) errno = EACCES;