mirror of git://git.musl-libc.org/musl
fix microblaze atomic store
as far as I can tell, microblaze is strongly ordered, but this does not seem to be well-documented and the assumption may need revisiting. even with strong ordering, however, a volatile C assignment is not sufficient to implement atomic store, since it does not preclude reordering by the compiler with respect to non-volatile stores and loads. simply flanking a C store with empty volatile asm blocks with memory clobbers would achieve the desired result, but is likely to result in worse code generation, since the address and value for the store may need to be spilled. actually writing the store in asm, so that there's only one asm block, should give optimal code generation while satisfying the requirement for having a compiler barrier.
This commit is contained in:
parent
1456b7ae6b
commit
884cc0c7e2
|
@ -95,7 +95,9 @@ static inline void a_dec(volatile int *x)
|
|||
|
||||
static inline void a_store(volatile int *p, int x)
|
||||
{
|
||||
*p=x;
|
||||
__asm__ __volatile__ (
|
||||
"swi %1, %0"
|
||||
: "=m"(*p) : "r"(x) : "memory" );
|
||||
}
|
||||
|
||||
static inline void a_spin()
|
||||
|
|
Loading…
Reference in New Issue