mirror of
git://git.musl-libc.org/musl
synced 2025-02-04 13:01:37 +00:00
inet_pton: fix uninitialized memory use for IPv4-mapped IPv6 addresses
When a dot is encountered, the loop counter is incremented before exiting the loop, but the corresponding ip array element is left uninitialized, so the subsequent memmove (if "::" was seen) and the loop copying ip to the output buffer will operate on an uninitialized uint16_t. The uninitialized data never directly influences the control flow and is overwritten on successful return by the second half of the parsed IPv4 address. But it's better to fix this to avoid unexpected transformations by a sufficiently smart compiler and reports from UB-detection tools.
This commit is contained in:
parent
7e6da7ac98
commit
7e13e5ae69
@ -54,6 +54,7 @@ int inet_pton(int af, const char *restrict s, void *restrict a0)
|
||||
if (s[j]!='.' || (i<6 && brk<0)) return 0;
|
||||
need_v4=1;
|
||||
i++;
|
||||
ip[i&7]=0;
|
||||
break;
|
||||
}
|
||||
s += j+1;
|
||||
|
Loading…
Reference in New Issue
Block a user