mirror of git://git.musl-libc.org/musl
ensure valid setxid return value in an unexpected error case
If __synccall() fails to capture all threads because tkill fails for some reason other than EAGAIN, then the callback given will never be executed, so nothing will ever overwrite the initial value. So that is the value that will be returned from the function. The previous setting of 1 is not a valid value for setuid() et al. to return. I chose -EAGAIN since I don't know the reason the synccall failed ahead of time, but EAGAIN is a specified error code for a possibly temporary failure in setuid().
This commit is contained in:
parent
7f3a292536
commit
7bb11f75c5
|
@ -30,5 +30,5 @@ int __setxid(int nr, int id, int eid, int sid)
|
|||
* trigger the safety kill above. */
|
||||
struct ctx c = { .nr = nr, .id = id, .eid = eid, .sid = sid, .ret = 1 };
|
||||
__synccall(do_setxid, &c);
|
||||
return __syscall_ret(c.ret);
|
||||
return __syscall_ret(c.ret > 0 ? -EAGAIN : c.ret);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue