RepoMirrors/musl
1
0
Fork 0
mirror of git://git.musl-libc.org/musl synced 2025-01-26 16:43:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

disable sbrk for all values of increment except 0

Browse Source 
use of sbrk is never safe; it conflicts with malloc, and malloc may be
used internally by the implementation basically anywhere. prior to
this change, applications attempting to use sbrk to do their own heap
management simply caused untrackable memory corruption; now, they will
fail with ENOMEM allowing the errors to be fixed.

sbrk(0) is still permitted as a way to get the current brk; some
misguided applications use this as a measurement of their memory
usage or for other related purposes, and such usage is harmless.

eventually sbrk may be re-added if/when malloc is changed to avoid
using the brk by using mmap for all allocations.
This commit is contained in:
Rich Felker 2014-01-02 17:03:34 -05:00
parent 5c81b8fe45
commit 7a995fe706
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/linux/sbrk.c
View File

@ -1,9 +1,9 @@
#include <stdint.h>
#include <errno.h>
#include "syscall.h"
void *sbrk(intptr_t inc)
{
unsigned long cur = syscall(SYS_brk, 0);
if (inc && syscall(SYS_brk, cur+inc) != cur+inc) return (void *)-1;
return (void *)cur;
if (inc) return (void *)__syscall_ret(-ENOMEM);
return (void *)__syscall(SYS_brk, 0);
}