RepoMirrors/musl
1
0
Fork 0
mirror of git://git.musl-libc.org/musl synced 2024-12-15 19:25:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

superh: fix dynamic linking of __fpscr_values

Browse Source 
Applications ended up with copy relocations for this array, which
resulted in libc's references to this array pointing to the
application's copy.  The dynamic linker, however, can require this array
before the application is relocated, and therefore before the
application's copy of this array is initialized.  This resulted in
garbage being loaded into FPSCR before executing main, which violated
the ABI.

We fix this by putting the array in crt1 and making the libc copy
private.  This prevents libc's reference to the array from pointing to
an uninitialized copy in the application.
This commit is contained in:
Bobby Bingham 2014-03-16 16:17:28 -05:00
parent 2b47a7aff2
commit 611eabd489
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/sh/crt_arch.h
View File

@ -7,3 +7,6 @@ _start: \n\
bsr __cstart \n\
nop \n\
");
/* used by gcc for switching the FPU between single and double precision */
const unsigned long __fpscr_values[2] = { 0, 0x80000 };

5
arch/sh/src/__fpsrc_values.c
View File

@ -1,2 +1,5 @@
#include "libc.h"
/* used by gcc for switching the FPU between single and double precision */
const unsigned long __fpscr_values[2] = { 0, 0x80000 };
const unsigned long __fpscr_values[2] ATTR_LIBC_VISIBILITY = { 0, 0x80000 };