RepoMirrors
/
musl
mirror of git://git.musl-libc.org/musl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

adjust mips crt_arch entry point asm to avoid assembler bugs 

apparently the .gpword directive does not work reliably with local
text labels; values produced were offset by 64k from the correct
value, resulting in incorrect computation of the got pointer at
runtime. instead, use an external label so that the assembler does not
munge the relocation; the linker will then get it right.

commit 6fef8cafbd exposed this issue by
removing the old, non-PIE-compatible handwritten crt1.s, which was not
affected. presumably mips PIE executables (using Scrt1.o produced from
crt_arch.h) were already affected at the time.
This commit is contained in:
Rich Felker 2015-12-29 13:01:29 -05:00
parent 71991a803c
commit 5e396fb996
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
arch/mips/crt_arch.h
View File

@ -4,13 +4,16 @@ __asm__(
".text \n"
".global _" START "\n"
".global " START "\n"
".global " START "_data\n"
".type _" START ", @function\n"
".type " START ", @function\n"
".type " START "_data, @function\n"
"_" START ":\n"
"" START ":\n"
" bal 1f \n"
" move $fp, $0 \n"
"2: .gpword 2b \n"
"" START "_data: \n"
" .gpword " START "_data \n"
" .gpword " START "_c \n"
".weak _DYNAMIC \n"
".hidden _DYNAMIC \n"