RepoMirrors/musl
1
0
Fork 0
mirror of git://git.musl-libc.org/musl synced 2025-03-01 17:20:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

explicitly reject empty names in dynamic linker load_library function

Browse Source 
previously passing an empty string for name resulted in failure, as
expected, but only after spurious syscalls, and it produced confusing
errno values (and thus dlerror strings).

in addition to dlopen calls, this issue affected use of LD_PRELOAD
with trailing whitespace or colon characters.
This commit is contained in:
Rich Felker 2014-07-11 00:29:44 -04:00
parent 349381aa8c
commit 59549313d8
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/ldso/dynlink.c
View File

@ -663,6 +663,11 @@ static struct dso *load_library(const char *name, struct dso *needed_by)
int n_th = 0; int n_th = 0;
int is_self = 0; int is_self = 0;
if (!*name) {
errno = EINVAL;
return 0;
}
/* Catch and block attempts to reload the implementation itself */ /* Catch and block attempts to reload the implementation itself */
if (name[0]=='l' && name[1]=='i' && name[2]=='b') { if (name[0]=='l' && name[1]=='i' && name[2]=='b') {
static const char *rp, reserved[] = static const char *rp, reserved[] =