RepoMirrors
/
musl
mirror of git://git.musl-libc.org/musl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add missing memory barrier to pthread_join 

POSIX requires pthread_join to synchronize memory on success.  The
futex wait inside __timedwait_cp cannot handle this because it's not
called in all cases.  Also, in the case of a spurious wake, tid can
become zero between the wake and when the joining thread checks it.
This commit is contained in:
Bobby Bingham 2015-10-04 14:55:29 -05:00 committed by Rich Felker
parent bde0b4b92e
commit 53cd8c5a29
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/thread/pthread_join.c
View File

@ -13,6 +13,7 @@ int __pthread_join(pthread_t t, void **res)
if (cs == PTHREAD_CANCEL_ENABLE) __pthread_setcancelstate(cs, 0); if (cs == PTHREAD_CANCEL_ENABLE) __pthread_setcancelstate(cs, 0);
while ((tmp = t->tid)) __timedwait_cp(&t->tid, tmp, 0, 0, 0); while ((tmp = t->tid)) __timedwait_cp(&t->tid, tmp, 0, 0, 0);
__pthread_setcancelstate(cs, 0); __pthread_setcancelstate(cs, 0);
a_barrier();
if (res) *res = t->result; if (res) *res = t->result;
if (t->map_base) __munmap(t->map_base, t->map_size); if (t->map_base) __munmap(t->map_base, t->map_size);
return 0; return 0;