RepoMirrors
/
musl
mirror of git://git.musl-libc.org/musl
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove O_NOFOLLOW from __map_file used for time zone file loading 

it's not clear why I originally wrote O_NOFOLLOW into this; I suspect
the reason was with an aim of making the function more general for
mapping partially or fully untrusted files provided by the user.
however, the timezone code already precludes use of absolute or
relative pathnames in suid/sgid programs, and disallows .. in
pathnames which are relative to one of the system timezone locations,
so there is no threat of opening a symlink which is not trusted by
appropriate user. since some users may wish to put symbolic links in
the zoneinfo directories to alias timezones, it seems preferable to
allow this.
This commit is contained in:
Rich Felker 2013-11-08 21:33:42 -05:00
parent 1d0d2df609
commit 41a9ba25cd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/time/__map_file.c
View File

@ -9,7 +9,7 @@ const char unsigned *__map_file(const char *pathname, size_t *size)
{
struct stat st;
const unsigned char *map = MAP_FAILED;
int flags = O_RDONLY|O_LARGEFILE|O_CLOEXEC|O_NOFOLLOW|O_NONBLOCK;
int flags = O_RDONLY|O_LARGEFILE|O_CLOEXEC|O_NONBLOCK;
int fd = __syscall(SYS_open, pathname, flags);
if (fd < 0) return 0;
if (!__syscall(SYS_fstat, fd, &st))