mirror of
git://git.musl-libc.org/musl
synced 2024-12-18 21:05:13 +00:00
disallow non-absolute rpath $ORIGIN for suid/sgid/AT_SECURE processes
in theory non-absolute origins can only arise when either the main program is invoked by running ldso as a command (inherently non-suid) or when dlopen was called with a relative pathname containing at least one slash. such usage would be inherently insecure in an suid program anyway, so the old behavior here does not seem to have been insecure. harden against it anyway.
This commit is contained in:
parent
f0b235c138
commit
376b3c54bb
@ -817,6 +817,9 @@ static int fixup_rpath(struct dso *p, char *buf, size_t buf_size)
|
||||
origin = ".";
|
||||
l = 1;
|
||||
}
|
||||
/* Disallow non-absolute origins for suid/sgid/AT_SECURE. */
|
||||
if (libc.secure && *origin != '/')
|
||||
return 0;
|
||||
p->rpath = malloc(strlen(p->rpath_orig) + n*l + 1);
|
||||
if (!p->rpath) return -1;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user