fix redundant computations of strlen in glob append function

len was already passed as an argument, so don't use strcat, and use
memcpy instead of strcpy.
This commit is contained in:
Rich Felker 2018-10-11 14:27:15 -04:00
parent e2552581bc
commit 09a805a623
1 changed files with 5 additions and 2 deletions

View File

@ -41,8 +41,11 @@ static int append(struct match **tail, const char *name, size_t len, int mark)
if (!new) return -1;
(*tail)->next = new;
new->next = NULL;
strcpy(new->name, name);
if (mark) strcat(new->name, "/");
memcpy(new->name, name, len+1);
if (mark) {
new->name[len] = '/';
new->name[len+1] = 0;
}
*tail = new;
return 0;
}