mirror of
https://github.com/mpv-player/mpv
synced 2025-01-02 21:12:23 +00:00
c5e4538bc4
this is meant to replace the old and not properly working vo_gpu/opengl cocoa backend in the future. the problems are various shortcomings of Apple's opengl implementation and buggy behaviour in certain circumstances that couldn't be properly worked around. there are also certain regressions on newer macOS versions from 10.11 onwards. - awful opengl performance with a none layer backed context - huge amount of dropped frames with an early context flush - flickering of system elements like the dock or volume indicator - double buffering not properly working with a none layer backed context - bad performance in fullscreen because of system optimisations all the problems were caused by using a normal opengl context, that seems somewhat abandoned by apple, and are fixed by using a layer backed opengl context instead. problems that couldn't be fixed could be properly worked around. this has all features our old backend has sans the wid embedding, the possibility to disable the automatic GPU switching and taking screenshots of the window content. the first was deemed unnecessary by me for now, since i just use the libmpv API that others can use anyway. second is technically not possible atm because we have to pre-allocate our opengl context at a time the config isn't read yet, so we can't get the needed property. third one is a bit tricky because of deadlocking and it needed to be in sync, hopefully i can work around that in the future. this also has at least one additional feature or eye-candy. a properly working fullscreen animation with the native fs. also since this is a direct port of the old backend of the parts that could be used, though with adaptions and improvements, this looks a lot cleaner and easier to understand. some credit goes to @pigoz for the initial swift build support which i could improve upon. Fixes: #5478, #5393, #5152, #5151, #4615, #4476, #3978, #3746, #3739, #2392, #2217
222 lines
5.8 KiB
C
222 lines
5.8 KiB
C
/*
|
|
* This file is part of mpv.
|
|
*
|
|
* mpv is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* mpv is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with mpv. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <OpenGL/OpenGL.h>
|
|
#include <dlfcn.h>
|
|
#include "options/m_config.h"
|
|
#include "video/out/cocoa_common.h"
|
|
#include "context.h"
|
|
|
|
struct cocoa_opts {
|
|
int cocoa_force_dedicated_gpu;
|
|
};
|
|
|
|
#define OPT_BASE_STRUCT struct cocoa_opts
|
|
const struct m_sub_options cocoa_conf = {
|
|
.opts = (const struct m_option[]) {
|
|
OPT_FLAG("cocoa-force-dedicated-gpu", cocoa_force_dedicated_gpu, 0),
|
|
{0}
|
|
},
|
|
.size = sizeof(struct cocoa_opts),
|
|
};
|
|
|
|
struct priv {
|
|
GL gl;
|
|
void (GLAPIENTRY *Flush)(void);
|
|
CGLPixelFormatObj pix;
|
|
CGLContextObj ctx;
|
|
|
|
struct cocoa_opts *opts;
|
|
};
|
|
|
|
static int set_swap_interval(int enabled)
|
|
{
|
|
CGLContextObj ctx = CGLGetCurrentContext();
|
|
CGLError err = CGLSetParameter(ctx, kCGLCPSwapInterval, &enabled);
|
|
return (err == kCGLNoError) ? 0 : -1;
|
|
}
|
|
|
|
static void glFlushDummy(void) { }
|
|
|
|
static void *cocoa_glgetaddr(const char *s)
|
|
{
|
|
void *ret = NULL;
|
|
void *handle = dlopen(
|
|
"/System/Library/Frameworks/OpenGL.framework/OpenGL",
|
|
RTLD_LAZY | RTLD_LOCAL);
|
|
if (!handle)
|
|
return NULL;
|
|
ret = dlsym(handle, s);
|
|
dlclose(handle);
|
|
return ret;
|
|
}
|
|
|
|
static CGLError test_gl_version(struct ra_ctx *ctx, CGLOpenGLProfile ver)
|
|
{
|
|
struct priv *p = ctx->priv;
|
|
|
|
CGLPixelFormatAttribute attrs[] = {
|
|
// let this array ordered by the inverse order of the most probably
|
|
// rejected attribute to preserve the fallback code
|
|
kCGLPFAOpenGLProfile,
|
|
(CGLPixelFormatAttribute) ver,
|
|
kCGLPFAAccelerated,
|
|
kCGLPFAAllowOfflineRenderers,
|
|
// keep this one last to apply the cocoa-force-dedicated-gpu option
|
|
kCGLPFASupportsAutomaticGraphicsSwitching,
|
|
0
|
|
};
|
|
|
|
GLint npix;
|
|
CGLError err;
|
|
int supported_attribute = MP_ARRAY_SIZE(attrs)-1;
|
|
|
|
if (p->opts->cocoa_force_dedicated_gpu)
|
|
attrs[--supported_attribute] = 0;
|
|
|
|
err = CGLChoosePixelFormat(attrs, &p->pix, &npix);
|
|
while (err == kCGLBadAttribute && supported_attribute > 3) {
|
|
// kCGLPFASupportsAutomaticGraphicsSwitching is probably not
|
|
// supported by the current hardware. Falling back to not using
|
|
// it and disallowing Offline Renderers if further restrictions
|
|
// apply
|
|
attrs[--supported_attribute] = 0;
|
|
err = CGLChoosePixelFormat(attrs, &p->pix, &npix);
|
|
}
|
|
|
|
if (err != kCGLNoError) {
|
|
MP_ERR(ctx->vo, "error creating CGL pixel format: %s (%d)\n",
|
|
CGLErrorString(err), err);
|
|
goto error_out;
|
|
}
|
|
|
|
err = CGLCreateContext(p->pix, 0, &p->ctx);
|
|
|
|
error_out:
|
|
return err;
|
|
}
|
|
|
|
static bool create_gl_context(struct ra_ctx *ctx)
|
|
{
|
|
struct priv *p = ctx->priv;
|
|
GL *gl = &p->gl;
|
|
CGLError err;
|
|
|
|
CGLOpenGLProfile gl_versions[] = {
|
|
kCGLOGLPVersion_3_2_Core,
|
|
kCGLOGLPVersion_Legacy,
|
|
};
|
|
|
|
for (int n = 0; n < MP_ARRAY_SIZE(gl_versions); n++) {
|
|
err = test_gl_version(ctx, gl_versions[n]);
|
|
if (err == kCGLNoError)
|
|
break;
|
|
}
|
|
|
|
if (err != kCGLNoError) {
|
|
MP_FATAL(ctx->vo, "error creating CGL context: %s (%d)\n",
|
|
CGLErrorString(err), err);
|
|
return false;
|
|
}
|
|
|
|
vo_cocoa_set_opengl_ctx(ctx->vo, p->ctx);
|
|
CGLSetCurrentContext(p->ctx);
|
|
|
|
if (ctx->opts.want_alpha)
|
|
CGLSetParameter(p->ctx, kCGLCPSurfaceOpacity, &(GLint){0});
|
|
|
|
mpgl_load_functions(gl, (void *)cocoa_glgetaddr, NULL, ctx->vo->log);
|
|
gl->SwapInterval = set_swap_interval;
|
|
p->Flush = gl->Flush;
|
|
gl->Flush = glFlushDummy;
|
|
|
|
CGLReleasePixelFormat(p->pix);
|
|
|
|
return true;
|
|
}
|
|
|
|
static void cocoa_uninit(struct ra_ctx *ctx)
|
|
{
|
|
struct priv *p = ctx->priv;
|
|
ra_gl_ctx_uninit(ctx);
|
|
CGLReleaseContext(p->ctx);
|
|
vo_cocoa_uninit(ctx->vo);
|
|
}
|
|
|
|
static void cocoa_swap_buffers(struct ra_ctx *ctx)
|
|
{
|
|
struct priv *p = ctx->priv;
|
|
vo_cocoa_swap_buffers(ctx->vo);
|
|
p->Flush();
|
|
}
|
|
|
|
static bool cocoa_init(struct ra_ctx *ctx)
|
|
{
|
|
struct priv *p = ctx->priv = talloc_zero(ctx, struct priv);
|
|
GL *gl = &p->gl;
|
|
p->opts = mp_get_config_group(ctx, ctx->global, &cocoa_conf);
|
|
vo_cocoa_init(ctx->vo);
|
|
|
|
MP_WARN(ctx->vo, "opengl cocoa backend is deprecated, use opengl-cb instead\n");
|
|
|
|
if (!create_gl_context(ctx))
|
|
goto fail;
|
|
|
|
struct ra_gl_ctx_params params = {
|
|
.swap_buffers = cocoa_swap_buffers,
|
|
};
|
|
|
|
if (!ra_gl_ctx_init(ctx, gl, params))
|
|
goto fail;
|
|
|
|
return true;
|
|
|
|
fail:
|
|
cocoa_uninit(ctx);
|
|
return false;
|
|
}
|
|
|
|
static void resize(struct ra_ctx *ctx)
|
|
{
|
|
ra_gl_ctx_resize(ctx->swapchain, ctx->vo->dwidth, ctx->vo->dheight, 0);
|
|
}
|
|
|
|
static bool cocoa_reconfig(struct ra_ctx *ctx)
|
|
{
|
|
vo_cocoa_config_window(ctx->vo);
|
|
resize(ctx);
|
|
return true;
|
|
}
|
|
|
|
static int cocoa_control(struct ra_ctx *ctx, int *events, int request,
|
|
void *arg)
|
|
{
|
|
int ret = vo_cocoa_control(ctx->vo, events, request, arg);
|
|
if (*events & VO_EVENT_RESIZE)
|
|
resize(ctx);
|
|
return ret;
|
|
}
|
|
|
|
const struct ra_ctx_fns ra_ctx_cocoa = {
|
|
.type = "opengl",
|
|
.name = "cocoa",
|
|
.init = cocoa_init,
|
|
.reconfig = cocoa_reconfig,
|
|
.control = cocoa_control,
|
|
.uninit = cocoa_uninit,
|
|
};
|