1
0
mirror of https://github.com/mpv-player/mpv synced 2025-01-13 18:45:25 +00:00
Command line video player
Go to file
wm4 fc04be708c x11: fix race condition when setting aspect when leaving fullscreen
vo_opengl creates a hidden X11 window to probe the OpenGL context. It
must do that before creating a visible window, because VO creation and
VO config are separate phases.

There's a race condition involving the hidden window: when starting with
--fs, and then leaving fullscreen, the unfullscreened window is
sometimes set to the aspect ratio of the hidden window. I'm not sure why
the window size itself uses the correct size (but corrupted by the wrong
aspect), but that's perhaps because the window manager is free to ignore
the size hint while honoring the aspect, or something equally messed up.

It turns out this happens because x11_common.c thinks the size of the
hidden window is the size of the unfullscreened window. This in turn
happens because vo_x11_update_geometry() reads the size of the hidden
window when called in vo_x11_fullscreen() (called from
vo_x11_config_vo_window()) when mapping the fullscreen window. At that
point, the window could be mapped, but not necessarily. If it's not
mapped, it will get the size of the unfullscreened window... I think.

One could fix this by actively waiting until the window is mapped. Try
to pick a less hacky approach instead, and never read the window size
until MapNotify is received.

vo_x11_create_window() needs a hack, because we'd possibly set the VO's
size to 0, resulting e.g. in vdpau to fail initialization. (It'll print
error messages until a proper resize is received.)
2014-02-02 01:35:46 +01:00
audio w32: use safe DLL search paths everywhere 2014-01-27 10:04:29 +01:00
bstr bstr: add function for splitting UTF-8 2014-01-15 16:13:07 +01:00
common msg: don't clear the status line if new and previous status was empty 2014-01-29 17:15:05 +01:00
compat build: make configure fail if both __atomic and __sync are not available 2014-01-01 20:52:54 +01:00
demux demux_mkv: remove unused field 2014-01-31 19:49:48 +01:00
DOCS quvi: disable subtitle fetching by default 2014-01-31 00:46:52 +01:00
etc mpv.desktop: add some more mimetypes 2014-01-18 22:42:59 +01:00
input threads: add wrapper for initializing recursive mutexes 2014-01-31 19:50:25 +01:00
misc charset_conv: mp_msg conversions 2013-12-21 21:43:16 +01:00
options quvi: disable subtitle fetching by default 2014-01-31 00:46:52 +01:00
osdep threads: add function to calculate deadline for timed waits 2014-01-31 22:17:43 +01:00
player w32: use safe DLL search paths everywhere 2014-01-27 10:04:29 +01:00
stream cache: refuse to seek outside of cache boundaries 2014-01-31 22:40:35 +01:00
sub threads: add wrapper for initializing recursive mutexes 2014-01-31 19:50:25 +01:00
ta ta: check overflow in array realloc macros 2014-01-02 23:54:59 +01:00
TOOLS ildetect: add ILDETECT_FORCE_RUN (if interlacing could not be decided, assume yadif). 2013-12-18 10:56:33 +01:00
video x11: fix race condition when setting aspect when leaving fullscreen 2014-02-02 01:35:46 +01:00
waftools build: switch to -std=c99 for saner float semantics 2014-02-02 00:00:14 +01:00
.gitignore Fix OSX build; remove all remaining mpvcore references 2013-12-17 08:44:21 +01:00
.travis.yml travis: disable e-mail notifications 2013-11-23 22:31:44 +01:00
bootstrap.py bootstrap.py: reindent to 4 spaces 2013-11-26 21:35:37 +01:00
Copyright
LICENSE
old-configure old-configure: use -std=c99 2014-02-02 00:54:56 +01:00
old-makefile w32: use the w32_common keymap in terminal-win too 2014-01-19 14:42:15 +01:00
README.md build: hide duplicate options from --help 2013-12-26 10:09:17 +01:00
talloc.h
travis-deps travis: remove --disable-doc from libav/ffmpeg configure 2013-11-24 14:47:33 +01:00
version.sh
wscript waf: rename --enable-sdl to --enable-sdl1 2014-01-25 00:30:28 +01:00
wscript_build.py waf: rename --enable-sdl to --enable-sdl1 2014-01-25 00:30:28 +01:00

mpv

Build Status

Overview

mpv is a movie player based on MPlayer and mplayer2. It supports a wide variety of video file formats, audio and video codecs, and subtitle types.

If you are wondering what's different from mplayer2 and MPlayer you can read more about the changes.

Compilation

Compiling with full features requires development files for several external libraries. Below is a list of some important requirements.

The mpv build system uses waf but we don't store it in your source tree. The script './bootstrap.py' will download the latest version of waf that was tested with the build system.

For a list of the available build options use ./waf configure --help. If you think you have support for some feature installed but configure fails to detect it, the file build/config.log may contain information about the reasons for the failure.

NOTE: To avoid cluttering the output with unreadable spam, --help only shows one of the two switches for each option. If the option is autodetected by default, the --disable-*** switch is printed; if the option is disabled by default, the --enable-*** switch is printed. Either way, you can use --enable-*** or --disable-** regardless of what is printed by --help.

To build the software you can use ./waf build: the result of the compilation will be located in build/mpv. You can use ./waf install to install mpv to the prefix after it is compiled.

NOTE: Using the old build system (with ./old-configure) should still work, but will be removed in a future version of mpv.

Essential dependencies (incomplete list):

  • gcc or clang
  • X development headers (xlib, X extensions, libvdpau, libGL, libXv, ...)
  • Audio output development headers (libasound, pulseaudio)
  • fribidi, freetype, fontconfig development headers (for libass)
  • libass
  • FFmpeg libraries (libavutil libavcodec libavformat libswscale libpostproc)
  • libjpeg
  • libquvi if you want to play Youtube videos directly
  • libx264/libmp3lame/libfdk-aac if you want to use encoding (has to be explicitly enabled when compiling ffmpeg)

Most of the above libraries are available in suitable versions on normal Linux distributions. However FFmpeg is an exception (distro versions may be too old to work at all or work well). For that reason you may want to use the separately available build wrapper (mpv-build) that first compiles FFmpeg libraries and libass, and then compiles the player statically linked against those.

If you are running Mac OSX and using homebrew we provide homebrew-mpv, an up to date formula that compiles mpv with sensible dependencies and defaults for OSX.

FFmpeg vs. Libav

Generally, mpv should work with the latest release as well as the git version of both FFmpeg and Libav. But FFmpeg is preferred, and some mpv features work with FFmpeg only. See the wiki article about the issue.

Bug reports

Please use the issue tracker provided by GitHub to send us bug reports or feature requests.

Contributing

For small changes you can just send us pull requests through GitHub. For bigger changes come and talk to us on IRC before you start working on them. It will make code review easier for both parties later on.

Contacts

These forms of contact are meant to ask questions about mpv usage, give feedback on mpv and discuss it's development.

If possible, please avoid posting bugs here and use the issue tracker instead.

  • Users IRC Channel: #mpv-player on irc.freenode.net
  • Users Mailing List: mpv-users@googlegroups.com (Archive / Subscribe).
  • Devel Mailing List: mpv-devel@googlegroups.com (Archive / Subscribe)

To contact the mpv team in private write to mpv-team@googlegroups.com.