mirror of https://github.com/mpv-player/mpv
b18c2d9fe2
Key bindings are decided on the "down" event, so if the prefix is not unique, the first/shortest will be used (e.g. when both "a" and "a-b" are mapped, "a" will always be chosen). This also breaks combining multiple mouse buttons. But it seems users expect it to work, and it's indeed a bit strange that it shouldn't work, as mouse bindings are emitted on the key "up" event, not "down" (if the shorter binding didn't emit a command yet, why shouldn't it be combinable). Deal with this by clearing the key history when a command is actually emitted, instead of when a command is decided. This means if both MOUSE_BTN0 and MOUSE_BTN0-MOUSE_BTN1 are mapped, the sequence of holding down BTN0 and then BTN1 will redecide the current command. On the other hand, if BTN0 is released before BTN1 is pressed, the command is emitted, and the key history is deleted. So the BTN1 press will not trigger BTN0-BTN1. For normal keys, nothing should change, because commands are emitted on the "down" event already, so the key history is always cleared. Might fix #902. CC: @mpv-player/stable (if this fix is successful) |
||
|---|---|---|
| .. | ||
| cmd_list.c | ||
| cmd_list.h | ||
| cmd_parse.c | ||
| cmd_parse.h | ||
| event.c | ||
| event.h | ||
| input.c | ||
| input.h | ||
| joystick.c | ||
| joystick.h | ||
| keycodes.c | ||
| keycodes.h | ||
| lirc.c | ||
| lirc.h | ||