mirror of https://github.com/mpv-player/mpv
f8e62d3d82
The EGL stuff is really complicated because of historical reasons (tl;dr: blame EGL). There was one edge case with EGL context creation that lead to incorrect behavior. EGL_KHR_create_context was created with EGL 1.4 (which mpv does support) but it is still possible for an EGL 1.4 device to not implement this extension. That means that none of the EGL attrs that pass a specific opengl version work. So for this obscure case, there is a fallback context creation at the very end which simply creates an EGLContext without passing any special attrs. This has another problem however. mpv has a hard requirement on at least desktop opengl 2.1 or opengl ES 2.0 to function (we're not asking for much here). Since the fallback EGL context creation has no version checking, it is entirely possible to create an EGL context with a desktop opengl version under 2.1. As you get further along in the code, the user will encounter the hard opengl version check and then error out. However, we're supposed to also actually check if GLES works (that's what the opengl-es=auto option is for) so this is a bug. The fix is to do a bit of code duplication and make a mpgl_check_version specifically for if we hit the edge case of needing to create an EGL context without the EGL_KHR_create_context extension. Grab the version with the function pointer, check if it's under 210, if so destroy the EGL context and set it to NULL. After that, if the user has set opengl-es to auto, mpv will try GLES next. If it is set to no, then mpv will simply fail as desired. Fixes #5915. Sidenote: the ra_gl_ctx_test_version originally testing 140 doesn't make any sense. Passing the version number in that function only does something if the user has set opengl-restrict. What we need to do is to pass the version of the created context to that function. If the version is higher than the opengl-restrict option, then make this a failure. |
||
|---|---|---|
| .. | ||
| angle_dynamic.c | ||
| angle_dynamic.h | ||
| common.c | ||
| common.h | ||
| context.c | ||
| context.h | ||
| context_android.c | ||
| context_angle.c | ||
| context_cocoa.c | ||
| context_drm_egl.c | ||
| context_dxinterop.c | ||
| context_glx.c | ||
| context_rpi.c | ||
| context_wayland.c | ||
| context_win.c | ||
| context_x11egl.c | ||
| egl_helpers.c | ||
| egl_helpers.h | ||
| formats.c | ||
| formats.h | ||
| gl_headers.h | ||
| hwdec_d3d11egl.c | ||
| hwdec_drmprime_drm.c | ||
| hwdec_dxva2egl.c | ||
| hwdec_dxva2gldx.c | ||
| hwdec_ios.m | ||
| hwdec_osx.c | ||
| hwdec_rpi.c | ||
| hwdec_vdpau.c | ||
| libmpv_gl.c | ||
| oml_sync.c | ||
| oml_sync.h | ||
| ra_gl.c | ||
| ra_gl.h | ||
| utils.c | ||
| utils.h | ||