mirror of
https://github.com/mpv-player/mpv
synced 2024-12-19 13:21:13 +00:00
c36faf8c49
There were subtle and minor race conditions in the pull.c code, and AOs using it (jack, portaudio, sdl, wasapi). Attempt to remove these. There was at least a race condition in the ao_reset() implementation: mp_ring_reset() was called concurrently to the audio callback. While the ringbuffer uses atomics to allow concurrent access, the reset function wasn't concurrency-safe (and can't easily be made to). Fix this by stopping the audio callback before doing a reset. After that, we can do anything without needing synchronization. The callback is resumed when resuming playback at a later point. Don't call driver->pause, and make driver->resume and driver->reset start/stop the audio callback. In the initial state, the audio callback must be disabled. JackAudio of course is different. Maybe there is no way to suspend the audio callback without "disconnecting" it (what jack_deactivate() would do), so I'm not trying my luck, and implemented a really bad hack doing active waiting until we get the audio callback into a state where it won't interfere. Once the callback goes from AO_STATE_WAIT to NONE, we can be sure that the callback doesn't access the ringbuffer or anything else anymore. Since both sched_yield() and pthread_yield() apparently are not always available, use mp_sleep_us(1) to avoid burning CPU during active waiting. The ao_jack.c change also removes a race condition: apparently we didn't initialize _all_ ao fields before starting the audio callback. In ao_wasapi.c, I'm not sure whether reset really waits for the audio callback to return. Kovensky says it's not guaranteed, so disable the reset callback - for now the behavior of ao_wasapi.c is like with ao_jack.c, and active waiting is used to deal with the audio callback. |
||
|---|---|---|
| .. | ||
| ao_alsa.c | ||
| ao_coreaudio_properties.c | ||
| ao_coreaudio_properties.h | ||
| ao_coreaudio_utils.c | ||
| ao_coreaudio_utils.h | ||
| ao_coreaudio.c | ||
| ao_dsound.c | ||
| ao_jack.c | ||
| ao_lavc.c | ||
| ao_null.c | ||
| ao_openal.c | ||
| ao_oss.c | ||
| ao_pcm.c | ||
| ao_portaudio.c | ||
| ao_pulse.c | ||
| ao_rsound.c | ||
| ao_sdl.c | ||
| ao_sndio.c | ||
| ao_wasapi_utils.c | ||
| ao_wasapi_utils.h | ||
| ao_wasapi.c | ||
| ao_wasapi.h | ||
| ao.c | ||
| ao.h | ||
| internal.h | ||
| pull.c | ||
| push.c | ||