mirror of
https://github.com/mpv-player/mpv
synced 2025-01-19 05:41:16 +00:00
bc28f7693d
mpv's core does not propagate option notifications unless they actually change to the rest of the player. Most of the time, this makes perfect sense. If the user sets fullscreen multiple times, there's no reason to care about anything other than the change in state. However, there are certain options where it makes sense to always broadcast a notification even if the value doesn't change. For example, consider the window-scale case. A user may set window-scale to some value, resize the window further through some other means (such as mouse resizing) and then want to set the window-scale again to the same value as earlier. The window-scale value did not change from before so no notification is sent and nothing happens even though it is desirable and expected that it operates again. This was solved by making the current-window-scale property writable a few years ago, but actually the easier solution is to just always force the option to update on any write. For the big callback, the needed changes are trivial. Unfortunately, it requires a hot mess in order to have this work with the m_config_cache_update APIs. Spooky stuff in there, but it does send the notification now. |
||
|---|---|---|
| .. | ||
| m_config_core.c | ||
| m_config_core.h | ||
| m_config_frontend.c | ||
| m_config_frontend.h | ||
| m_config.h | ||
| m_option.c | ||
| m_option.h | ||
| m_property.c | ||
| m_property.h | ||
| options.c | ||
| options.h | ||
| parse_commandline.c | ||
| parse_commandline.h | ||
| parse_configfile.c | ||
| parse_configfile.h | ||
| path.c | ||
| path.h | ||