1
0
mirror of https://github.com/mpv-player/mpv synced 2024-12-22 14:52:43 +00:00
mpv/options
Dudemanguy a2dd78fbc0 options: restore old default sub selection behavior
1669c4698d notably flipped the default of
--subs-with-matching-audio from yes to no as part of a series of changes
that gave more control over sub selection behavior. While the increased
amount of options is definitely nice, changing the default to no results
in very unintuitive behavior. For example, setting alang=en and slang=en
in your config will not show any subtitles since the audio stream is
English as well so --subs-with-matching-audio being no causes the subs
to not be be selected. This is very weird for users who reasonably
expect slang being set to actually result in showing subs and this is
what mpv did for the past decade.

The other case is when a subtitle does not have a language tag but is
flagged as default. Because --subs-fallback (a new option), defaults to
no, these subtitles also will not be loaded. This is also strange for
users since mpv previously loaded these and they would need to change
the value of this option. It's also inconsistent because audio tracks
that are tagged as default are also loaded by default.

The new behavior seems to have mostly just confused users, and it also
regresses their configs for unclear reasons. Let's just set the options
to be back in line with the old behavior with is what most users expect.
--subs-with-matching-audio goes back to being yes and the new option
--subs-fallback should be default. Fixes #11854.
2023-07-29 22:22:37 +02:00
..
m_config_core.c osdep: rename MP_UNREACHABLE 2021-11-03 15:15:20 +01:00
m_config_core.h
m_config_frontend.c options: log profile name if there is no restore data 2022-10-28 15:48:24 +00:00
m_config_frontend.h options: add watch-later-options 2021-07-21 13:19:28 +00:00
m_config.h
m_option.c various: fix typos 2023-03-28 19:29:44 +00:00
m_option.h client API: reintroduce CONF_TYPE_FLAG for type conversion 2023-02-27 11:21:49 +01:00
m_property.c options: change parameter that was forgottin in property transition 2023-02-27 11:21:49 +01:00
m_property.h options: change parameter that was forgottin in property transition 2023-02-27 11:21:49 +01:00
options.c options: restore old default sub selection behavior 2023-07-29 22:22:37 +02:00
options.h demux_playlist: add option to control recursive directory loading 2023-07-06 18:17:45 +00:00
parse_commandline.c various: drop unused #include "config.h" 2023-02-20 14:21:18 +00:00
parse_commandline.h
parse_configfile.c options: read config file as stream 2023-04-29 22:34:54 +00:00
parse_configfile.h options: read config file as stream 2023-04-29 22:34:54 +00:00
path.c path: handle URLs consistently in mp_basename 2023-06-01 22:47:48 +02:00
path.h path: expand internal path selection API to allow for additional types 2023-05-09 20:37:17 +00:00