mirror of
https://github.com/mpv-player/mpv
synced 2025-01-30 11:42:04 +00:00
9a210ca2d5
Something like "char *s = ...; isdigit(s[0]);" triggers undefined behavior, because char can be signed, and thus s[0] can be a negative value. The is*() functions require unsigned char _or_ EOF. EOF is a special value outside of unsigned char range, thus the argument to the is*() functions can't be a char. This undefined behavior can actually trigger crashes if the implementation of these functions e.g. uses lookup tables, which are then indexed with out-of-range values. Replace all <ctype.h> uses with our own custom mp_is*() functions added with misc/ctype.h. As a bonus, these functions are locale-independent. (Although currently, we _require_ C locale for other reasons.) |
||
|---|---|---|
| .. | ||
| codec_tags.c | ||
| codec_tags.h | ||
| demux_cue.c | ||
| demux_edl.c | ||
| demux_lavf.c | ||
| demux_libass.c | ||
| demux_mf.c | ||
| demux_mkv.c | ||
| demux_playlist.c | ||
| demux_raw.c | ||
| demux_subreader.c | ||
| demux.c | ||
| demux.h | ||
| ebml.c | ||
| ebml.h | ||
| matroska.h | ||
| mf.c | ||
| mf.h | ||
| ms_hdr.h | ||
| packet.h | ||
| stheader.h | ||