mirror of
https://github.com/mpv-player/mpv
synced 2025-01-09 08:29:36 +00:00
bda32d99d7
So far, switching between integrated and discrete GPU would cause the kernel to kill mpv due to an indecipherable buffer error. The technical note TN2229 from Apple recommends to enable OpenGL Offline Renderers for every Mac with more GPUs than displays to handle the switch between GPU. By ordering the array from the least commonly rejected to the most, we can sequentially remove PixelFormat attributes to fit the host. Fixes #2371
191 lines
5.2 KiB
C
191 lines
5.2 KiB
C
/*
|
|
* This file is part of mpv.
|
|
*
|
|
* mpv is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* mpv is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with mpv. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <OpenGL/OpenGL.h>
|
|
#include <dlfcn.h>
|
|
#include "options/m_config.h"
|
|
#include "video/out/cocoa_common.h"
|
|
#include "osdep/macosx_versions.h"
|
|
#include "context.h"
|
|
|
|
struct cocoa_opts {
|
|
int cocoa_force_dedicated_gpu;
|
|
};
|
|
|
|
#define OPT_BASE_STRUCT struct cocoa_opts
|
|
const struct m_sub_options cocoa_conf = {
|
|
.opts = (const struct m_option[]) {
|
|
OPT_FLAG("cocoa-force-dedicated-gpu", cocoa_force_dedicated_gpu, 0),
|
|
{0}
|
|
},
|
|
.size = sizeof(struct cocoa_opts),
|
|
};
|
|
|
|
struct priv {
|
|
CGLPixelFormatObj pix;
|
|
CGLContextObj ctx;
|
|
|
|
struct cocoa_opts *opts;
|
|
};
|
|
|
|
static int set_swap_interval(int enabled)
|
|
{
|
|
CGLContextObj ctx = CGLGetCurrentContext();
|
|
CGLError err = CGLSetParameter(ctx, kCGLCPSwapInterval, &enabled);
|
|
return (err == kCGLNoError) ? 0 : -1;
|
|
}
|
|
|
|
static void *cocoa_glgetaddr(const char *s)
|
|
{
|
|
void *ret = NULL;
|
|
void *handle = dlopen(
|
|
"/System/Library/Frameworks/OpenGL.framework/OpenGL",
|
|
RTLD_LAZY | RTLD_LOCAL);
|
|
if (!handle)
|
|
return NULL;
|
|
ret = dlsym(handle, s);
|
|
dlclose(handle);
|
|
return ret;
|
|
}
|
|
|
|
static CGLError test_gl_version(struct MPGLContext *ctx, CGLOpenGLProfile ver)
|
|
{
|
|
struct priv *p = ctx->priv;
|
|
|
|
CGLPixelFormatAttribute attrs[] = {
|
|
// let this array ordered by the inverse order of the most probably
|
|
// rejected attribute to preserve the fallback code
|
|
kCGLPFAOpenGLProfile,
|
|
(CGLPixelFormatAttribute) ver,
|
|
kCGLPFAAccelerated,
|
|
kCGLPFAAllowOfflineRenderers,
|
|
// keep this one last to apply the cocoa-force-dedicated-gpu option
|
|
kCGLPFASupportsAutomaticGraphicsSwitching,
|
|
0
|
|
};
|
|
|
|
GLint npix;
|
|
CGLError err;
|
|
int supported_attribute = MP_ARRAY_SIZE(attrs)-1;
|
|
|
|
if (p->opts->cocoa_force_dedicated_gpu)
|
|
attrs[--supported_attribute] = 0;
|
|
|
|
err = CGLChoosePixelFormat(attrs, &p->pix, &npix);
|
|
while (err == kCGLBadAttribute && supported_attribute > 3) {
|
|
// kCGLPFASupportsAutomaticGraphicsSwitching is probably not
|
|
// supported by the current hardware. Falling back to not using
|
|
// it and disallowing Offline Renderers if further restrictions
|
|
// apply
|
|
attrs[--supported_attribute] = 0;
|
|
err = CGLChoosePixelFormat(attrs, &p->pix, &npix);
|
|
}
|
|
|
|
if (err != kCGLNoError) {
|
|
MP_ERR(ctx->vo, "error creating CGL pixel format: %s (%d)\n",
|
|
CGLErrorString(err), err);
|
|
goto error_out;
|
|
}
|
|
|
|
err = CGLCreateContext(p->pix, 0, &p->ctx);
|
|
|
|
error_out:
|
|
return err;
|
|
}
|
|
|
|
static bool create_gl_context(struct MPGLContext *ctx, int vo_flags)
|
|
{
|
|
struct priv *p = ctx->priv;
|
|
CGLError err;
|
|
|
|
CGLOpenGLProfile gl_versions[] = {
|
|
kCGLOGLPVersion_3_2_Core,
|
|
kCGLOGLPVersion_Legacy,
|
|
};
|
|
|
|
for (int n = 0; n < MP_ARRAY_SIZE(gl_versions); n++) {
|
|
err = test_gl_version(ctx, gl_versions[n]);
|
|
if (err == kCGLNoError)
|
|
break;
|
|
}
|
|
|
|
if (err != kCGLNoError) {
|
|
MP_FATAL(ctx->vo, "error creating CGL context: %s (%d)\n",
|
|
CGLErrorString(err), err);
|
|
return false;
|
|
}
|
|
|
|
vo_cocoa_set_opengl_ctx(ctx->vo, p->ctx);
|
|
CGLSetCurrentContext(p->ctx);
|
|
|
|
if (vo_flags & VOFLAG_ALPHA)
|
|
CGLSetParameter(p->ctx, kCGLCPSurfaceOpacity, &(GLint){0});
|
|
|
|
mpgl_load_functions(ctx->gl, (void *)cocoa_glgetaddr, NULL, ctx->vo->log);
|
|
|
|
CGLReleasePixelFormat(p->pix);
|
|
|
|
return true;
|
|
}
|
|
|
|
static void cocoa_uninit(MPGLContext *ctx)
|
|
{
|
|
struct priv *p = ctx->priv;
|
|
CGLReleaseContext(p->ctx);
|
|
vo_cocoa_uninit(ctx->vo);
|
|
}
|
|
|
|
static int cocoa_init(MPGLContext *ctx, int vo_flags)
|
|
{
|
|
struct priv *p = ctx->priv;
|
|
p->opts = mp_get_config_group(ctx, ctx->global, &cocoa_conf);
|
|
vo_cocoa_init(ctx->vo);
|
|
|
|
if (!create_gl_context(ctx, vo_flags))
|
|
return -1;
|
|
|
|
ctx->gl->SwapInterval = set_swap_interval;
|
|
return 0;
|
|
}
|
|
|
|
static int cocoa_reconfig(struct MPGLContext *ctx)
|
|
{
|
|
vo_cocoa_config_window(ctx->vo);
|
|
return 0;
|
|
}
|
|
|
|
static int cocoa_control(struct MPGLContext *ctx, int *events, int request,
|
|
void *arg)
|
|
{
|
|
return vo_cocoa_control(ctx->vo, events, request, arg);
|
|
}
|
|
|
|
static void cocoa_swap_buffers(struct MPGLContext *ctx)
|
|
{
|
|
vo_cocoa_swap_buffers(ctx->vo);
|
|
ctx->gl->Flush();
|
|
}
|
|
|
|
const struct mpgl_driver mpgl_driver_cocoa = {
|
|
.name = "cocoa",
|
|
.priv_size = sizeof(struct priv),
|
|
.init = cocoa_init,
|
|
.reconfig = cocoa_reconfig,
|
|
.swap_buffers = cocoa_swap_buffers,
|
|
.control = cocoa_control,
|
|
.uninit = cocoa_uninit,
|
|
}; |