mirror of https://github.com/mpv-player/mpv
b430c886aa
This should fix some issues, such as not being able to set the "no-video" option with MPV_FORMAT_FLAG. Note that this changes semantics a bit. Now setting an option strictly overwrite it, even if the corresponding command line option does not. For example, if we change --sub to append by default, then setting the "sub" option via the client API would still never append. (Oddly, this also applies to --vf-add, which will overwrite the old value when using the client API.) I'm doing this because there's no proper separation between the command line parser and setting an option using the MPV_FORMAT_STRING format. Maybe the solution to this mess would be adding format aware code (i.e. m_option_set_node) to every option type, and falling back to strings only if needed - but this would mean that you couldn't set e.g. an integer option using MPV_FORMAT_STRING, which doesn't seem to be ideal either. In conclusion, the current approach seems to be most robust, but I'm open to suggestions should someone find that these semantics are a problem. |
||
|---|---|---|
| .. | ||
| m_config.c | ||
| m_config.h | ||
| m_option.c | ||
| m_option.h | ||
| m_property.c | ||
| m_property.h | ||
| options.c | ||
| options.h | ||
| parse_commandline.c | ||
| parse_commandline.h | ||
| parse_configfile.c | ||
| parse_configfile.h | ||
| path.c | ||
| path.h | ||