mirror of
https://github.com/mpv-player/mpv
synced 2025-01-03 13:32:16 +00:00
fb9bbf2a0d
This gets rid of run_command() and its big switch statement, which was an idiotically big function of almost 1000 lines. The switch is replaced with a callback per command, and each command is now implemented in its own function. Command IDs are not needed anymore, so the mp_command_type enum disappears. There should be no functional changes, but since this refactors 64 commands, regressions are possible. The handler() parameter is void*, because in theory the input code is supposed to be independent of the player core code. For example, you should be able to reuse the command parser code for some other part of mpv. In practice, the variable containing command list is defined in the player core anyway, so you could say this doesn't work. But I'm still trying to hold onto this idea, so I went with void*.
60 lines
1.8 KiB
C
60 lines
1.8 KiB
C
/*
|
|
* This file is part of mpv.
|
|
*
|
|
* mpv is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* mpv is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with mpv. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef MP_COMMAND_LIST_H
|
|
#define MP_COMMAND_LIST_H
|
|
|
|
#include <stdbool.h>
|
|
#include "options/m_option.h"
|
|
|
|
#define MP_CMD_DEF_MAX_ARGS 9
|
|
|
|
#define MP_CMD_OPT_ARG 0x1000
|
|
|
|
struct mp_cmd_ctx;
|
|
|
|
struct mp_cmd_def {
|
|
const char *name; // user-visible name (as used in input.conf)
|
|
void (*handler)(void *ctx);
|
|
const struct m_option args[MP_CMD_DEF_MAX_ARGS];
|
|
const void *priv; // for free use by handler()
|
|
bool allow_auto_repeat; // react to repeated key events
|
|
bool on_updown; // always emit it on both up and down key events
|
|
bool vararg; // last argument can be given 0 to multiple times
|
|
bool scalable;
|
|
bool is_abort;
|
|
bool is_soft_abort;
|
|
bool is_ignore;
|
|
};
|
|
|
|
extern const struct mp_cmd_def mp_cmds[];
|
|
|
|
// Executing this command will maybe abort playback (play something else, or quit).
|
|
struct mp_cmd;
|
|
bool mp_input_is_maybe_abort_cmd(struct mp_cmd *cmd);
|
|
// This command will definitely abort playback.
|
|
bool mp_input_is_abort_cmd(struct mp_cmd *cmd);
|
|
|
|
bool mp_input_is_repeatable_cmd(struct mp_cmd *cmd);
|
|
|
|
bool mp_input_is_scalable_cmd(struct mp_cmd *cmd);
|
|
|
|
struct mp_log;
|
|
void mp_print_cmd_list(struct mp_log *out);
|
|
|
|
#endif
|