mirror of
https://github.com/mpv-player/mpv
synced 2024-12-25 00:02:13 +00:00
775e08ba65
When blending OSD and subtitles onto the video, we write bogus alpha values. This doesn't normally matter, because these values are normally unused and discarded. But at least on Wayland, the alpha values are used by the compositor and leads to transparent windows even with opaque video on places where the OSD happens to use transparency. (Also see github issue #338.) Until now, the alpha basically contained garbage. The source factor GL_SRC_ALPHA meant that alpha was multiplied with itself. Use GL_ONE instead (which is why we have to use glBlendFuncSeparate()). This should give correct results, even with video that has alpha. (Or at least it's something close to correct, I haven't thought too hard how the compositor will blend it, and in fact I couldn't manage to test it.) If glBlendFuncSeparate() is not available, fall back to glBlendFunc(), which does the same as the code did before this commit. Technically, we support GL 1.1, but glBlendFuncSeparate is 1.4, and I guess we should try not to crash if vo_opengl_old runs on a system with GL 1.1 drivers only. |
||
|---|---|---|
| .. | ||
| decode | ||
| filter | ||
| out | ||
| csputils.c | ||
| csputils.h | ||
| fmt-conversion.c | ||
| fmt-conversion.h | ||
| image_writer.c | ||
| image_writer.h | ||
| img_format.c | ||
| img_format.h | ||
| img_fourcc.h | ||
| memcpy_pic.h | ||
| mp_image_pool.c | ||
| mp_image_pool.h | ||
| mp_image.c | ||
| mp_image.h | ||
| sws_utils.c | ||
| sws_utils.h | ||
| vaapi.c | ||
| vaapi.h | ||
| vdpau_functions.inc | ||
| vdpau.c | ||
| vdpau.h | ||
| vfcap.h | ||