mirror of https://github.com/mpv-player/mpv
ea4685b233
The old way of using wayland in mpv relied on an external renderloop for semi-accurate timings. This had multiple issues though. Display sync would break whenever the window was hidden (since the frame callback stopped being executed) which was really annoying. Also the entire external renderloop logic was kind of fragile and didn't play well with mpv's internal structure (i.e. using presentation time in that old paradigm breaks stats.lua). Basically the problem is that swap buffers blocks on wayland which is crap whenever you hide the mpv window since it looks up the entire player. So you have to make swap buffers not block, but this has a different problem. Timings will be terrible if you use the unblocked swap buffers call. Based on some discussion in #wayland, the trick here is relatively simple and works well enough for our purposes. Instead we basically build a way to block with a timeout in the wayland buffer swap functions. A bool is set in the frame callback function that indicates whether or not mpv is waiting for a frame to be displayed. In the actual buffer swap function, we enter into a while loop waiting for this flag to be set. At the same time, the wl_display is polled to block the thread and wakeup if it receives any events from the compositor. This loop only breaks if enough time has passed or if the frame callback bool is received. In the near future, it is better to set whether or not frame a frame has been displayed in the presentation feedback. However as a first pass, doing it in the frame callback is more than good enough. The "downside" is that we render frames that aren't actually shown on screen when the player is hidden (it seems like wayland people don't like that). But who cares. Accurate timings are way more important. It's probably not too hard to add that behavior back in the player though. |
||
|---|---|---|
| .. | ||
| angle_dynamic.c | ||
| angle_dynamic.h | ||
| common.c | ||
| common.h | ||
| context.c | ||
| context.h | ||
| context_android.c | ||
| context_angle.c | ||
| context_cocoa.c | ||
| context_drm_egl.c | ||
| context_dxinterop.c | ||
| context_glx.c | ||
| context_rpi.c | ||
| context_wayland.c | ||
| context_win.c | ||
| context_x11egl.c | ||
| egl_helpers.c | ||
| egl_helpers.h | ||
| formats.c | ||
| formats.h | ||
| gl_headers.h | ||
| hwdec_d3d11egl.c | ||
| hwdec_d3d11eglrgb.c | ||
| hwdec_drmprime_drm.c | ||
| hwdec_dxva2egl.c | ||
| hwdec_dxva2gldx.c | ||
| hwdec_ios.m | ||
| hwdec_osx.c | ||
| hwdec_rpi.c | ||
| hwdec_vdpau.c | ||
| libmpv_gl.c | ||
| oml_sync.c | ||
| oml_sync.h | ||
| ra_gl.c | ||
| ra_gl.h | ||
| utils.c | ||
| utils.h | ||