mirror of https://github.com/mpv-player/mpv
ba70b150fb
When the current file changes (or rather, when starting/finishing playback of a playlist entry), clients tend to have the problem that it's hard to tell whether a property change notification (via mpv_observe_property() and mechanisms layered on top of it) is from the previous or new playlist entry. The previous commit probably helps, but all the asynchronity is still a bit unhelpful. Try to make this better by adding new hooks, that are run before/after playback init/deinit. This is similar to the existing hooks, except they're outside of "initialized" playback, which excludes that you might accidentally get an overlap between the current and the previous/next playlist entry. That still doesn't seem quite enough, since normally, property change notifications come after the hook event. So basically a client would have to explicitly "drain" the event queue within the hook, and make the hook continue only after that is done. Knowing when property notifications are done is another asynchronous nightmare (how exactly it works keeps changing within client.c, and an API user probably can't tell anymore when all pending properties are truly done). So introduce another guarantee: properties that were changed before the hook happens will be returned before the hook event is returned. That means the client will have received all pending property notifications from the previous playlist entry (or whatever) before the hook is entered. As another minor complication, we shouldn't just keep the hook pending until _all_ property notifications are done, since the client's hook could produce new ones. (Or just consider things like the demuxer thread hammering the client with cache update events, while the "on_preloaded" hook is run.) So there is some extra untested, fragile logic in client.c to handle this (the waiting_for_hook flag). This probably works, but was barely tested. Not sure if this helps anyone, but I think it's fine for my own purposes. (I really hated this aspect of the API whenever I used it myself.) |
||
|---|---|---|
| .. | ||
| lua | ||
| mpv-osd-symbols.sfdir | ||
| osxbundle/mpv.app/Contents | ||
| __init__.py | ||
| appveyor-build.sh | ||
| appveyor-install.sh | ||
| dylib-unhell.py | ||
| file2string.py | ||
| gen-osd-font.sh | ||
| idet.sh | ||
| matroska.py | ||
| mpv_identify.sh | ||
| osxbundle.py | ||
| stats-conv.py | ||
| travis-deps | ||
| travis-rebuild-website | ||
| umpv | ||
| uncrustify.cfg | ||