mirror of https://github.com/mpv-player/mpv
413c6f5b30
This crash happened when audio channels were reconfigured from 6 channels to 2, and playback speed was set to 2. The crash is caused by passing a negative size to memcpy. It appears reinitialization doesn't clear the buffer. As the result, the buffer can be larger as the maximum buffer size, i.e. the invariant bytes_queued <= bytes_queue is violated. Fix this by resetting the buffer length on reconfiguring (set the bytes_queued vairable to 0). Also reset some other state for clarity and robustness, although these changes aren't strictly needed for avoiding the actual crash. This may also get rid of some noise played right after reinitialization, as the re-used buffer was in the wrong audio format. |
||
|---|---|---|
| DOCS | ||
| TOOLS | ||
| debian | ||
| etc | ||
| ffmpeg_files | ||
| input | ||
| libaf | ||
| libao2 | ||
| libmpcodecs | ||
| libmpdemux | ||
| libvo | ||
| osdep | ||
| rpm | ||
| stream | ||
| sub | ||
| timeline | ||
| .gitignore | ||
| AUTHORS | ||
| Copyright | ||
| LICENSE | ||
| Makefile | ||
| README | ||
| asxparser.c | ||
| asxparser.h | ||
| av_log.c | ||
| av_log.h | ||
| av_opts.c | ||
| av_opts.h | ||
| bstr.c | ||
| bstr.h | ||
| cfg-mplayer.h | ||
| codec-cfg.c | ||
| codec-cfg.h | ||
| command.c | ||
| command.h | ||
| configure | ||
| cpudetect.c | ||
| cpudetect.h | ||
| defaultopts.c | ||
| defaultopts.h | ||
| fmt-conversion.c | ||
| fmt-conversion.h | ||
| image_writer.c | ||
| image_writer.h | ||
| m_config.c | ||
| m_config.h | ||
| m_option.c | ||
| m_option.h | ||
| m_property.c | ||
| m_property.h | ||
| m_struct.c | ||
| m_struct.h | ||
| mangle.h | ||
| metadata.h | ||
| mixer.c | ||
| mixer.h | ||
| mp_core.h | ||
| mp_fifo.c | ||
| mp_fifo.h | ||
| mp_msg.c | ||
| mp_msg.h | ||
| mp_osd.h | ||
| mpbswap.h | ||
| mpcommon.c | ||
| mpcommon.h | ||
| mplayer.c | ||
| mplayer.h | ||
| options.h | ||
| parser-cfg.c | ||
| parser-cfg.h | ||
| parser-mpcmd.c | ||
| parser-mpcmd.h | ||
| path.c | ||
| path.h | ||
| playlist.c | ||
| playlist.h | ||
| playlist_parser.c | ||
| playlist_parser.h | ||
| pnm_loader.c | ||
| pnm_loader.h | ||
| screenshot.c | ||
| screenshot.h | ||
| subopt-helper.c | ||
| subopt-helper.h | ||
| talloc.c | ||
| talloc.h | ||
| version.sh | ||
README
Compiling with full features requires development files for several external libraries. Below is a list of some important requirements. For more information see the output of './configure --help' for a list of options, or look at the list of enabled and disabled features printed after running './configure'. If you think you have support for some feature installed but configure fails to detect it, the file config.log may contain information about the reasons for the failure. Libraries specific to particular video output methods (you'll want at least one of VDPAU, GL or Xv): - libvdpau (for VDPAU output, best choice for NVIDIA cards) - libGL (OpenGL output) - libXv (XVideo output) general: - libasound (ALSA audio output) - various general X development libraries - libfreetype (for libass) - libfontconfig (for libass) - libass - FFmpeg libraries (libavutil libavcodec libavformat libswscale libpostproc) Most of the above libraries are available in suitable versions on normal Linux distributions. However FFmpeg is an exception (distro versions may be too old to work at all or work well). For that reason you may want to use the separately available build wrapper that first compiles FFmpeg libraries and libass, and then compiles the player statically linked against those.