mirror of
https://github.com/mpv-player/mpv
synced 2025-03-01 20:00:37 +00:00
345342f50a
This has been a long standing problem that I think was the root cause for wm4's vaapi shitlist. As DRM explicit supports all possible rgba orderings, but OpenGL only guarantees support for 'rgba8', something has to happen to support import of dmabufs with non-native ordering. Although undocumented, it appears that somewhere in the import on the GL side, the ordering is swizzled to rgba - which makes sense as that's the only way to be able to support importing all the different formats. But we didn't know this, and we do our own swizzling based on the original imgfmt - which matches the drm format. So we get double swizzling and messed up colours. As there is no way for us to express that the GL swizzle happened to the rest of mpv, the easiest thing to do is fudge the format to the natural ordering so the GL doesn't change anything, then our swizzling will do the right thing in the end. Note that this change doesn't handle 0rgb and 0bgr because they seem to be affected by some additional feature/bug that is mangling the ordering somewhere that equally affects Vulkan interop. That could be a vaapi driver bug or something going on in ffmpeg. |
||
|---|---|---|
| .. | ||
| decode | ||
| filter | ||
| out | ||
| csputils.c | ||
| csputils.h | ||
| cuda.c | ||
| d3d.c | ||
| d3d.h | ||
| drmprime.c | ||
| fmt-conversion.c | ||
| fmt-conversion.h | ||
| hwdec.c | ||
| hwdec.h | ||
| image_loader.c | ||
| image_loader.h | ||
| image_writer.c | ||
| image_writer.h | ||
| img_format.c | ||
| img_format.h | ||
| mp_image_pool.c | ||
| mp_image_pool.h | ||
| mp_image.c | ||
| mp_image.h | ||
| repack.c | ||
| repack.h | ||
| sws_utils.c | ||
| sws_utils.h | ||
| vaapi.c | ||
| vaapi.h | ||
| vdpau_functions.inc | ||
| vdpau_mixer.c | ||
| vdpau_mixer.h | ||
| vdpau.c | ||
| vdpau.h | ||
| zimg.c | ||
| zimg.h | ||