1
0
mirror of https://github.com/mpv-player/mpv synced 2024-12-22 06:42:03 +00:00
mpv/audio
wm4 20988ee607 command: don't allow changing volume if no audio initialized
Changing volume when audio is disabled was a feature request (github
issue #215), and was introduced with commit 327a779.

But trying to fix github issue #280 (volume is not correct in no-audio
mode, and if audio is re-enabled, the volume set in no-audio mode isn't
set), I concluded that it's not worth the trouble and the current
implementation is questionable all around. (For example, you can't
change the real volume in no-audio mode, even if the AO is open - this
could happen with gapless audio.) It's hard to get right, and the
current mixer code is already hilariously overcomplicated. (Virtually
all of mixer.c is an amalgamation of various obscure corner cases.)

So just remove this feature again.

Note that "options/volume" and "options/mute" still can be used in
idle mode to adjust the volume used next time, though these properties
can't be used during playback and thus not in audio-only mode.

Querying the volume still "works" in audio-only mode, though it can
return bogus values.
2013-10-12 18:57:02 +02:00
..
decode ad_mpeg123: support in-stream format changes 2013-10-06 23:41:18 +02:00
filter af: merge af_reinit() and fix_output_format() 2013-09-20 13:43:00 +02:00
out ao_coreaudio: clear output buffer on buffer underrun 2013-10-03 23:43:07 +02:00
audio.c core: move contents to mpvcore (2/2) 2013-08-06 22:52:31 +02:00
audio.h
chmap_sel.c ao_jack: allow more control about channel layouts 2013-07-07 18:37:55 +02:00
chmap_sel.h audio: add channel map selection function 2013-05-12 21:24:57 +02:00
chmap.c core: move contents to mpvcore (2/2) 2013-08-06 22:52:31 +02:00
chmap.h core: move contents to mpvcore (2/2) 2013-08-06 22:52:31 +02:00
fmt-conversion.c core: move contents to mpvcore (2/2) 2013-08-06 22:52:31 +02:00
fmt-conversion.h
format.c audio: don't allow setting unknown formats from command line 2013-08-26 10:09:44 +02:00
format.h audio: make internal audio format 0 an invalid format 2013-08-26 10:09:41 +02:00
mixer.c command: don't allow changing volume if no audio initialized 2013-10-12 18:57:02 +02:00
mixer.h command: don't allow changing volume if no audio initialized 2013-10-12 18:57:02 +02:00
reorder_ch.c audio: fix compilation with older libavresample versions 2013-05-13 00:39:07 +02:00
reorder_ch.h audio: fix compilation with older libavresample versions 2013-05-13 00:39:07 +02:00