1e73da47da
If, for some reason, the subtitle renderer attempts to render a subtitle before SD_CTRL_SET_VIDEO_PARAMS was called, it passed a value calculated from invalid values. This can happen with --vf=sub and --start. The crash happens if 1. there was a subtitle packet that falls into the timestamp of the rendered video frame, 2. the playloop hasn't informed the subtitle decoder about the video resolution yet (normally unneeded, because that is used for weird corner cases only, so this code is a bit fuzzy), and 3. something actually requests a frame to be drawn from the subtitle renderer, like with vf_sub. The actual crash was due to passing NaN as pixel aspect to libass, which then created glyphs with ridiculous sizes, involving a few integer overflows and unchecked mallocs. The sd_lavc.c and sd_spu.c cases probably don't crash, but I'm not sure, and it's better fix them anyway. Not bothering with sd_spu.c, this crap is for compatibility and will be removed soon. Note that this would have been no problem, had the code checked whether SD_CTRL_SET_VIDEO_PARAMS was actually called. This commit adds such a check (although it basically checks after using the parameters). Regression since |
||
|---|---|---|
| DOCS | ||
| TOOLS | ||
| audio | ||
| bstr | ||
| common | ||
| compat | ||
| demux | ||
| etc | ||
| input | ||
| misc | ||
| options | ||
| osdep | ||
| player | ||
| stream | ||
| sub | ||
| ta | ||
| video | ||
| waftools | ||
| .gitignore | ||
| .travis.yml | ||
| Copyright | ||
| LICENSE | ||
| README.md | ||
| bootstrap.py | ||
| old-configure | ||
| old-makefile | ||
| talloc.h | ||
| travis-deps | ||
| version.sh | ||
| wscript | ||
| wscript_build.py | ||
README.md
mpv
Overview
mpv is a movie player based on MPlayer and mplayer2. It supports a wide variety of video file formats, audio and video codecs, and subtitle types.
If you are wondering what's different from mplayer2 and MPlayer you can read more about the changes.
Compilation
Compiling with full features requires development files for several external libraries. Below is a list of some important requirements.
The mpv build system uses waf but we don't store it in your source tree. The script './bootstrap.py' will download the latest version of waf that was tested with the build system.
For a list of the available build options use ./waf configure --help. If
you think you have support for some feature installed but configure fails to
detect it, the file build/config.log may contain information about the
reasons for the failure.
NOTE: To avoid cluttering the output with unreadable spam, --help only shows
one of the two switches for each option. If the option is autodetected by
default, the --disable-*** switch is printed; if the option is disabled by
default, the --enable-*** switch is printed. Either way, you can use
--enable-*** or --disable-** regardless of what is printed by --help.
To build the software you can use ./waf build: the result of the compilation
will be located in build/mpv. You can use ./waf install to install mpv
to the prefix after it is compiled.
NOTE: Using the old build system (with ./old-configure) should still work,
but will be removed in a future version of mpv.
Essential dependencies (incomplete list):
- gcc or clang
- X development headers (xlib, X extensions, libvdpau, libGL, libXv, ...)
- Audio output development headers (libasound, pulseaudio)
- fribidi, freetype, fontconfig development headers (for libass)
- libass
- FFmpeg libraries (libavutil libavcodec libavformat libswscale libpostproc)
- libjpeg
- libquvi if you want to play Youtube videos directly
- libx264/libmp3lame/libfdk-aac if you want to use encoding (has to be explicitly enabled when compiling ffmpeg)
Most of the above libraries are available in suitable versions on normal Linux distributions. However FFmpeg is an exception (distro versions may be too old to work at all or work well). For that reason you may want to use the separately available build wrapper (mpv-build) that first compiles FFmpeg libraries and libass, and then compiles the player statically linked against those.
If you are running Mac OSX and using homebrew we provide homebrew-mpv, an up to date formula that compiles mpv with sensible dependencies and defaults for OSX.
FFmpeg vs. Libav
Generally, mpv should work with the latest release as well as the git version of both FFmpeg and Libav. But FFmpeg is preferred, and some mpv features work with FFmpeg only. See the wiki article about the issue.
Bug reports
Please use the issue tracker provided by GitHub to send us bug reports or feature requests.
Contributing
For small changes you can just send us pull requests through GitHub. For bigger changes come and talk to us on IRC before you start working on them. It will make code review easier for both parties later on.
Contacts
These forms of contact are meant to ask questions about mpv usage, give feedback on mpv and discuss it's development.
If possible, please avoid posting bugs here and use the issue tracker instead.
- Users IRC Channel:
#mpv-playeronirc.freenode.net - Users Mailing List:
mpv-users@googlegroups.com(Archive / Subscribe). - Devel Mailing List:
mpv-devel@googlegroups.com(Archive / Subscribe)
To contact the mpv team in private write to mpv-team@googlegroups.com.