mirror of
https://github.com/mpv-player/mpv
synced 2024-12-19 05:15:12 +00:00
1151dac5f0
When the decoder detects a format change, it overwrites the values stored in sh_audio (this affects the members sample_format, samplerate, channels). In the case when the old audio data still needs to be played/filtered, the audio format as identified by sh_audio and the format used for the decoder buffer can mismatch. In particular, they will mismatch in the very unlikely but possible case the audio chain is reinitialized while old data is draining during a format change. Or in other words, sh_audio might contain the new format, while the audio chain is still configured to use the old format. Currently, the audio code (player/audio.c and init_audio_filters) access sh_audio to get the current format. This is in theory incorrect for the reasons mentioned above. Use the decoder buffer's format instead, which should be correct at any point. |
||
|---|---|---|
| .. | ||
| decode | ||
| filter | ||
| out | ||
| audio_buffer.c | ||
| audio_buffer.h | ||
| audio.c | ||
| audio.h | ||
| chmap_sel.c | ||
| chmap_sel.h | ||
| chmap.c | ||
| chmap.h | ||
| fmt-conversion.c | ||
| fmt-conversion.h | ||
| format.c | ||
| format.h | ||
| mixer.c | ||
| mixer.h | ||
| reorder_ch.c | ||
| reorder_ch.h | ||