mirror of
https://github.com/mpv-player/mpv
synced 2025-04-04 23:40:47 +00:00
10f51a8c57
Destruction (e.g. when closing the window) was a bit broken. This commit fixes some possible crashes, and should make lifetime management relatively sane. (Still a bit complex, though. Maybe this code should be moved into a tiny library.) QtQuick runs the renderer on a separate thread. This thread is rather loosely connected to the main thread. The loose separation is enforced by the API, which also makes coordination of initialization and destruction harder. Throw refcounting at the problem, which fixes it. The refcounting wrapper introduced in the previous commit is used for this. Also contains some general cleanups.
119 lines
3.5 KiB
C++
119 lines
3.5 KiB
C++
#include "mpvrenderer.h"
|
|
|
|
#include <QObject>
|
|
#include <QtGlobal>
|
|
#include <QOpenGLContext>
|
|
|
|
#include <QtGui/QOpenGLFramebufferObject>
|
|
|
|
#include <QtQuick/QQuickWindow>
|
|
|
|
class MpvRenderer : public QQuickFramebufferObject::Renderer
|
|
{
|
|
static void *get_proc_address(void *ctx, const char *name) {
|
|
(void)ctx;
|
|
QOpenGLContext *glctx = QOpenGLContext::currentContext();
|
|
if (!glctx)
|
|
return NULL;
|
|
return (void *)glctx->getProcAddress(QByteArray(name));
|
|
}
|
|
|
|
mpv::qt::Handle mpv;
|
|
QQuickWindow *window;
|
|
mpv_opengl_cb_context *mpv_gl;
|
|
public:
|
|
MpvRenderer(const MpvObject *obj)
|
|
: mpv(obj->mpv), window(obj->window()), mpv_gl(obj->mpv_gl)
|
|
{
|
|
int r = mpv_opengl_cb_init_gl(mpv_gl, NULL, get_proc_address, NULL);
|
|
if (r < 0)
|
|
throw "could not initialize OpenGL";
|
|
}
|
|
|
|
virtual ~MpvRenderer()
|
|
{
|
|
// Before we can really destroy the OpenGL state, we must make sure
|
|
// that the video output is destroyed. This is important for some
|
|
// forms of hardware decoding, where the decoder shares some state
|
|
// with the video output and the OpenGL context.
|
|
// Deselecting the video track is the easiest way to achieve this in
|
|
// a synchronous way. If no file is playing, setting the property
|
|
// will fail and do nothing.
|
|
mpv::qt::set_property_variant(mpv, "vid", "no");
|
|
|
|
mpv_opengl_cb_uninit_gl(mpv_gl);
|
|
}
|
|
|
|
void render()
|
|
{
|
|
QOpenGLFramebufferObject *fbo = framebufferObject();
|
|
int vp[4] = {0, 0, fbo->width(), fbo->height()};
|
|
window->resetOpenGLState();
|
|
mpv_opengl_cb_render(mpv_gl, fbo->handle(), vp);
|
|
window->resetOpenGLState();
|
|
}
|
|
};
|
|
|
|
MpvObject::MpvObject(QQuickItem * parent)
|
|
: QQuickFramebufferObject(parent), mpv_gl(0)
|
|
{
|
|
mpv = mpv::qt::Handle::FromRawHandle(mpv_create());
|
|
if (!mpv)
|
|
throw "could not create mpv context";
|
|
|
|
mpv_set_option_string(mpv, "terminal", "yes");
|
|
mpv_set_option_string(mpv, "msg-level", "all=v");
|
|
|
|
if (mpv_initialize(mpv) < 0)
|
|
throw "could not initialize mpv context";
|
|
|
|
// Make use of the MPV_SUB_API_OPENGL_CB API.
|
|
mpv::qt::set_option_variant(mpv, "vo", "opengl-cb");
|
|
|
|
// Request hw decoding, just for testing.
|
|
mpv::qt::set_option_variant(mpv, "hwdec", "auto");
|
|
|
|
// Setup the callback that will make QtQuick update and redraw if there
|
|
// is a new video frame. Use a queued connection: this makes sure the
|
|
// doUpdate() function is run on the GUI thread.
|
|
mpv_gl = (mpv_opengl_cb_context *)mpv_get_sub_api(mpv, MPV_SUB_API_OPENGL_CB);
|
|
if (!mpv_gl)
|
|
throw "OpenGL not compiled in";
|
|
mpv_opengl_cb_set_update_callback(mpv_gl, MpvObject::on_update, (void *)this);
|
|
connect(this, &MpvObject::onUpdate, this, &MpvObject::doUpdate,
|
|
Qt::QueuedConnection);
|
|
}
|
|
|
|
MpvObject::~MpvObject()
|
|
{
|
|
if (mpv_gl)
|
|
mpv_opengl_cb_set_update_callback(mpv_gl, NULL, NULL);
|
|
}
|
|
|
|
void MpvObject::on_update(void *ctx)
|
|
{
|
|
MpvObject *self = (MpvObject *)ctx;
|
|
emit self->onUpdate();
|
|
}
|
|
|
|
// connected to onUpdate(); signal makes sure it runs on the GUI thread
|
|
void MpvObject::doUpdate()
|
|
{
|
|
update();
|
|
}
|
|
|
|
void MpvObject::loadfile(const QString& filename)
|
|
{
|
|
QVariantList cmd;
|
|
cmd.append("loadfile");
|
|
cmd.append(filename);
|
|
mpv::qt::command_variant(mpv, cmd);
|
|
}
|
|
|
|
QQuickFramebufferObject::Renderer *MpvObject::createRenderer() const
|
|
{
|
|
window()->setPersistentOpenGLContext(true);
|
|
window()->setPersistentSceneGraph(true);
|
|
return new MpvRenderer(this);
|
|
}
|