RepoMirrors/mpv - mpv

Commit Graph

Author	SHA1	Message	Date
Philip Langdale	8c1f94f0e7	vo_gpu: hwdec_cuda: Synchronise OpenGL Interop Previously, there appeared to be implicit synchronisation in the GL interop path, and we never observed any visual glitches. However, recently, I started seeing stuttering in the GL path and on closer examination it looked like read-before-write behaviour where GL would display an old frame again rather than the current one. After verifying that disabling hwdec made the problem go away, I tried adding a cuStreamSynchronize() after the memcpys and that also resolved the problem, so it's clearly sync related. cuStreamSynchronize() is a CPU sync and so more heavy-weight than you want, but it's the only tool we have. There is no mechanism defined for synchronising GL to CUDA (It looks like there is a way to synchronise CUDA to EGL but it appears one way and so wouldn't directly address this problem). Anyway, empirically, the output now looks the same as with hwdec off.	2019-09-28 19:24:24 +03:00
Philip Langdale	237f5fa1b7	vo_gpu: hwdec_cuda: Improve interop selection mechanism This change updates the interop selection to match what I did for VAAPI, by iterating through an array of init functions until one of them works.	2019-09-15 17:51:47 -07:00
Philip Langdale	23a324215b	vo/gpu: hwdec_cuda: Refactor gpu api specific code into separate files The amount of code now present that's specific to Vulkan or OpenGL has reached the point where we really want to split it out to avoid a mess of #ifdefs. At the same time, I'm moving the code to an api neutral location.	2019-05-03 18:02:18 +02:00

Author

SHA1

Message

Date

Philip Langdale

8c1f94f0e7

vo_gpu: hwdec_cuda: Synchronise OpenGL Interop

Previously, there appeared to be implicit synchronisation in the
GL interop path, and we never observed any visual glitches. However,
recently, I started seeing stuttering in the GL path and on closer
examination it looked like read-before-write behaviour where GL
would display an old frame again rather than the current one.

After verifying that disabling hwdec made the problem go away,
I tried adding a cuStreamSynchronize() after the memcpys and that
also resolved the problem, so it's clearly sync related.

cuStreamSynchronize() is a CPU sync and so more heavy-weight than
you want, but it's the only tool we have. There is no mechanism
defined for synchronising GL to CUDA (It looks like there is a way
to synchronise CUDA to EGL but it appears one way and so wouldn't
directly address this problem).

Anyway, empirically, the output now looks the same as with hwdec
off.

2019-09-28 19:24:24 +03:00

Philip Langdale

237f5fa1b7

vo_gpu: hwdec_cuda: Improve interop selection mechanism

This change updates the interop selection to match what I did for
VAAPI, by iterating through an array of init functions until one
of them works.

2019-09-15 17:51:47 -07:00

Philip Langdale

23a324215b

vo/gpu: hwdec_cuda: Refactor gpu api specific code into separate files

The amount of code now present that's specific to Vulkan or OpenGL
has reached the point where we really want to split it out to
avoid a mess of #ifdefs.

At the same time, I'm moving the code to an api neutral location.

2019-05-03 18:02:18 +02:00

3 Commits